[BUG] Ensure that all headers build on their own #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
libcu++
miscco
force-pushed
the
ensure_all_headers_build
branch
from
f9236ad to
3a3c761
Compare
miscco
force-pushed
the
ensure_all_headers_build
branch
from
3a3c761 to
84e54f0
Compare
This only adds includes so running the tests is not necessary
miscco
force-pushed
the
ensure_all_headers_build
branch
from
84e54f0 to
4668c1f
Compare
wmaxey
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we are not testing that each internal header builds on its own.
This can lead to subtle include order dependencies.
Fixes #175