Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Ensure that all headers build on their own #200

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Jul 11, 2023

Currently we are not testing that each internal header builds on its own.

This can lead to subtle include order dependencies.

Fixes #175

@miscco miscco added libcu++ For all items related to libcu++ bug Something isn't working right. labels Jul 11, 2023
@miscco miscco requested a review from wmaxey July 11, 2023 15:37
@miscco miscco self-assigned this Jul 11, 2023
@miscco miscco force-pushed the ensure_all_headers_build branch from f9236ad to 3a3c761 Compare July 18, 2023 17:32
@miscco miscco requested review from a team as code owners July 18, 2023 17:32
@miscco miscco requested review from ericniebler and removed request for a team July 18, 2023 17:33
@miscco miscco force-pushed the ensure_all_headers_build branch from 3a3c761 to 84e54f0 Compare August 23, 2023 07:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This only adds includes so running the tests is not necessary
@miscco miscco force-pushed the ensure_all_headers_build branch from 84e54f0 to 4668c1f Compare August 23, 2023 11:16
@miscco miscco merged commit d0af9f7 into NVIDIA:main Sep 11, 2023
@miscco miscco deleted the ensure_all_headers_build branch September 11, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. libcu++ For all items related to libcu++
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Not all internal headers are compiling on their own
2 participants