-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore RAPIDS devcontainer #1955
Merged
bernhardmgruber
merged 2 commits into
NVIDIA:main
from
bdice:restore-rapids-devcontainer
Jul 8, 2024
Merged
Restore RAPIDS devcontainer #1955
bernhardmgruber
merged 2 commits into
NVIDIA:main
from
bdice:restore-rapids-devcontainer
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
approved these changes
Jul 8, 2024
Thanks @bernhardmgruber. Also, RAPIDS CI may not pass right now - see discussion in #1939. The PRs I have opened here (#1939 (comment)) will fix the broken patches. |
bernhardmgruber
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the script locally: Deleted all/various devcontainer subdirectories and the script restored them.
🟩 CI finished in 3h 15m: Pass: 100%/420 | Total: 2d 09h | Avg: 8m 13s | Max: 43m 24s | Hits: 85%/523096
|
Project | |
---|---|
+/- | CCCL Infrastructure |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
+/- | CCCL Infrastructure |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
🏃 Runner counts (total jobs: 420)
# | Runner |
---|---|
305 | linux-amd64-cpu16 |
64 | linux-amd64-gpu-v100-latest-1 |
28 | linux-arm64-cpu16 |
23 | windows-amd64-cpu16 |
alliepiper
added a commit
to alliepiper/cccl
that referenced
this pull request
Jul 9, 2024
This will catch issues like NVIDIA#1955 before they hit `main`.
jrhemstad
pushed a commit
that referenced
this pull request
Jul 9, 2024
This will catch issues like #1955 before they hit `main`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1935 removed the RAPIDS devcontainer configuration. Now CI shows errors like:
This PR restores the deleted devcontainer configuration.
See also: #1935 (comment)
Checklist