Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing comma in barrier __try_wait #1593

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

miscco
Copy link
Contributor

@miscco miscco commented Apr 4, 2024

Fixes #1592

Thanks a lot to @Artem-B for finding this

@miscco miscco requested review from a team as code owners April 4, 2024 18:49
@miscco miscco requested review from wmaxey, ericniebler, ahendriksen and griwes and removed request for ericniebler April 4, 2024 18:49
@miscco miscco added libcu++ For all items related to libcu++ bug: functional labels Apr 4, 2024
@miscco miscco enabled auto-merge (squash) April 4, 2024 18:50
@miscco miscco disabled auto-merge April 4, 2024 18:50
@miscco miscco enabled auto-merge (squash) April 4, 2024 18:50
Copy link
Contributor

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙀

@miscco miscco merged commit 8e97b4e into NVIDIA:main Apr 5, 2024
585 checks passed
@miscco miscco deleted the fix_missing_comma_barrier branch April 5, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: functional libcu++ For all items related to libcu++
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missing comma in try_wait() in __cuda/barrier.h
2 participants