Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: inconsistent use of macros to suppress doxygen document generation #2362

Closed
1 task done
ericniebler opened this issue Sep 4, 2024 · 1 comment · Fixed by #2921
Closed
1 task done

[BUG]: inconsistent use of macros to suppress doxygen document generation #2362

ericniebler opened this issue Sep 4, 2024 · 1 comment · Fixed by #2921
Labels
bug Something isn't working right. doc Documentation-related items.

Comments

@ericniebler
Copy link
Collaborator

Is this a duplicate?

Type of Bug

Something else

Component

Not sure

Describe the bug

In CCCL, I see uses of the following macros to control what parts of the code are processed by doxygen:

  • DOXYGEN_SHOULD_SKIP_THIS
  • THRUST_DOXYGEN
  • _LIBCUDACXX_DOXYGEN_INVOKED

From docs/repo.toml, it looks like the following are defined while doxygen is processing the code:

  • DOXYGEN_SHOULD_SKIP_THIS
  • DOXYGEN_ACTIVE

... and those only seem to be defined for the CUB and Thrust projects, not libcudacxx. This needs to be cleaned up and made consistent.

I suggest we switch everything to a _CCCL_DOXYGEN_INVOKED macro.

How to Reproduce

n/a

Expected behavior

n/a

Reproduction link

No response

Operating System

No response

nvidia-smi output

No response

NVCC version

No response

@ericniebler ericniebler added bug Something isn't working right. doc Documentation-related items. labels Sep 4, 2024
@github-project-automation github-project-automation bot moved this to Todo in CCCL Sep 4, 2024
@bernhardmgruber
Copy link
Contributor

I am happy about any solution that it is easily comprehendible in code. Currently, we use this a lot:

#ifndef DOXYGEN_SHOULD_SKIP_THIS
...
#endif

and if there weren't a trailing comment // Do not document I would not understand whether it skips the section or not (because the #ifndef is a negation).

ericniebler added a commit to ericniebler/cccl that referenced this issue Nov 21, 2024
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Nov 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right. doc Documentation-related items.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants