Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installation command #1690

Closed
wants to merge 2 commits into from
Closed

Commits on Jul 5, 2023

  1. Fix installation command

    `--build-option` is not the correct config setting to use; we need
    `--global-option`.
    
    Ref NVIDIA#1679.
    janEbert committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    b34aedc View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Add custom build backend to support build args

    This implements a custom build backend, inspired by [the solution used
    by Pillow](python-pillow/Pillow#7171).
    
    With this change, argument flags now need to be specified as key-value
    pairs instead of key-only as `--config-settings`. Every argument can
    either be left unspecified or have a value that is either "enabled" or
    "disabled".
    
    For example:
    
    ```
    --config-settings --global-option=--cpp_ext
    --global-option --cpp_ext
    ```
    
    becomes
    
    ```
    --config-settings cpp_ext=enabled
    ```
    
    The setuptools version requirement of 40.8.0 was also adopted from
    Pillow. It is the version that introduced the `build_meta:__legacy__`
    backend.
    janEbert committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ec98ef4 View commit details
    Browse the repository at this point in the history