[PyTorch] Decouple python quantization classes and refactor custom quantization - #2276
Conversation
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
for more information, see https://pre-commit.ci
|
/te-ci pytorch |
Signed-off-by: Evgeny <etsykunov@nvidia.com>
|
/te-ci pytorch |
|
/te-ci pytorch |
ksivaman
left a comment
There was a problem hiding this comment.
The main blocking issue is with some of the imports.
Could you detail in the description the motivation behind this change aside from the naming from experimental → custom? Why do we want to have a separate quantization_base.py outside of the tensor dir and why the decoupling of that from the quantization_helpers file which is inside the tensor dir?
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Evgeny Tsykunov <e.tsykunov@gmail.com>
Co-authored-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com> Signed-off-by: Evgeny Tsykunov <e.tsykunov@gmail.com>
The main idea is to help users more easily create custom recipes. For us, this can enable setting guards for this API change - if this file is getting changes, certain people might be alarmed etc. For the quantization_helpers, it contains some TE internal implementations that a general user might not need to know about, so I kept it in tensor submodule. With this PR, tensor submodule becomes a place for concrete implementations, but not base classes. |
|
Fair. I think the name |
Signed-off-by: Evgeny <etsykunov@nvidia.com>
Signed-off-by: Evgeny <etsykunov@nvidia.com>
|
/te-ci pytorch |
Description
Decouple python base quantization classes (aka API).
Keep "custom" instead of "experimental" naming convention.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: