Skip to content

[PyTorch] Fix tests for 🤗 integration#2239

Merged
ksivaman merged 2 commits intoNVIDIA:mainfrom
ksivaman:update_test_reqs
Oct 6, 2025
Merged

[PyTorch] Fix tests for 🤗 integration#2239
ksivaman merged 2 commits intoNVIDIA:mainfrom
ksivaman:update_test_reqs

Conversation

@ksivaman
Copy link
Member

@ksivaman ksivaman commented Oct 6, 2025

Description

HF transformers has torchao as a dependency, which only added safetensors support recently. transformers uses this feature without robust version checks for availability of this functionality. This is resulting in CI failures from our end. This is a workaround for a green CI until this is fixed properly in transformers.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

  • Include torchao minimum version for pytorch test requirements.

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman ksivaman requested a review from timmoon10 October 6, 2025 18:52
Signed-off-by: Kirthi Shankar Sivamani <ksivamani@nvidia.com>
@ksivaman
Copy link
Member Author

ksivaman commented Oct 6, 2025

/te-ci pytorch

Copy link
Collaborator

@timmoon10 timmoon10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ksivaman ksivaman merged commit 9f3e79b into NVIDIA:main Oct 6, 2025
21 of 23 checks passed
@ksivaman ksivaman deleted the update_test_reqs branch November 3, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants