Skip to content

Conversation

@pcastonguay
Copy link
Collaborator

@pcastonguay pcastonguay commented Dec 2, 2025

Fix was merged in #9311. Now unwaiving the test

Summary by CodeRabbit

  • Tests
    • Removed a test-skip entry, enabling a previously skipped test case to run.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 2, 2025

📝 Walkthrough

Walkthrough

A single test-skip entry was removed from the test waives configuration file. The entry for disaggregated/test_disaggregated.py::test_disaggregated_deepseek_v3_lite_bf16_empty_batch[DeepSeek-V3-Lite-bf16] was previously marked as skipped due to a bug reference and has now been removed.

Changes

Cohort / File(s) Summary
Test skip entry removal
tests/integration/test_lists/waives.txt
Removed one test-skip entry for DeepSeek-V3-Lite-bf16 empty batch test

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks required sections from template. The author provided only a one-line explanation and reference to PR #9311, leaving 'Description' and 'Test Coverage' sections empty. Complete the 'Description' section explaining the issue and the unwaive rationale, and the 'Test Coverage' section listing relevant tests now enabled.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title clearly describes the main change: removing a test skip entry for the disaggregated test. It directly corresponds to the changeset which removes a single test-skip entry from waives.txt.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26636 [ run ] triggered by Bot. Commit: 3702ae4

@Tabrizian
Copy link
Member

Thanks for creating the PR but the change is not in main yet. We need this MI to complete before we can merge this: #9594

@pcastonguay
Copy link
Collaborator Author

Thanks for creating the PR but the change is not in main yet. We need this MI to complete before we can merge this: #9594

My bad, didn't realize the PR was in release branch. Marking as Draft for now.

@pcastonguay pcastonguay changed the title [https://nvbugs/5601682][fix] Unwaiving disagg test Draft: [https://nvbugs/5601682][fix] Unwaiving disagg test Dec 2, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #26636 [ run ] completed with state SUCCESS. Commit: 3702ae4
/LLM/main/L0_MergeRequest_PR pipeline #20262 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@pcastonguay pcastonguay changed the title Draft: [https://nvbugs/5601682][fix] Unwaiving disagg test [https://nvbugs/5601682][fix] Unwaiving disagg test Dec 8, 2025
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
@pcastonguay pcastonguay force-pushed the unwaive_disagg_empty_batch_test branch from 3702ae4 to 35c16e4 Compare December 8, 2025 17:47
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27344 [ run ] triggered by Bot. Commit: 35c16e4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27344 [ run ] completed with state SUCCESS. Commit: 35c16e4
/LLM/main/L0_MergeRequest_PR pipeline #20889 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@pcastonguay
Copy link
Collaborator Author

/bot run --only-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27363 [ run ] triggered by Bot. Commit: 35c16e4

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27363 [ run ] completed with state SUCCESS. Commit: 35c16e4
/LLM/main/L0_MergeRequest_PR pipeline #20905 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast --add-multi-gpu-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27533 [ run ] triggered by Bot. Commit: 8054d17

Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27547 [ run ] triggered by Bot. Commit: 5edeefb

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27533 [ run ] completed with state ABORTED. Commit: 8054d17
LLM/main/L0_MergeRequest_PR #21012 (Blue Ocean) completed with status: ABORTED

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27547 [ run ] completed with state FAILURE. Commit: 5edeefb
LLM/main/L0_MergeRequest_PR #21024 (Blue Ocean) completed with status: ABORTED

@pcastonguay
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27572 [ run ] triggered by Bot. Commit: 5edeefb

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27572 [ run ] completed with state SUCCESS. Commit: 5edeefb
/LLM/main/L0_MergeRequest_PR pipeline #21042 completed with status: 'FAILURE'

@pcastonguay
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

1 similar comment
@pcastonguay
Copy link
Collaborator Author

/bot run --add-multi-gpu-test --disable-fail-fast

@pcastonguay
Copy link
Collaborator Author

/bot skip --comment "Only failing test is not related to my changes"

1 similar comment
@pcastonguay
Copy link
Collaborator Author

/bot skip --comment "Only failing test is not related to my changes"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27731 [ skip ] triggered by Bot. Commit: 5edeefb

@tensorrt-cicd
Copy link
Collaborator

PR_Github #27731 [ skip ] completed with state SUCCESS. Commit: 5edeefb
Skipping testing for commit 5edeefb

@pcastonguay pcastonguay merged commit 2c0293c into NVIDIA:main Dec 10, 2025
5 checks passed
usberkeley pushed a commit to usberkeley/TensorRT-LLM that referenced this pull request Dec 11, 2025
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 11, 2025
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
codego7250 pushed a commit to codego7250/TensorRT-LLM that referenced this pull request Dec 13, 2025
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
sherry-1001 pushed a commit to sherry-1001/TensorRT-LLM that referenced this pull request Dec 16, 2025
Signed-off-by: Patrice Castonguay <55748270+pcastonguay@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants