[https://nvbugs/5680310][fix] Fix ctx only timed out test

[pcastonguay]

Summary by CodeRabbit

• Improvements

  • Enhanced timeout messaging for KV cache transfer operations.

• Tests

  • Updated KV cache transfer backend configuration in test cases.
  • Re-enabled previously excluded test scenario for context-only KV cache exhaustion.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• Update tava architecture diagram if there is a significant design change in PR.

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[pcastonguay]

/bot run --disable-fail-fast

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes modify KV cache transfer functionality by updating a timeout log message for clarity, removing a test case from the exclusion list, and reconfiguring two test cases to use the UCX backend for KV cache transfer instead of the default backend.

Changes

Cohort / File(s)	Summary
Timeout log message cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp	Updated timeout log message in checkContextTransferStatus from "Timed out waiting for context transfer for request %ld after %d milliseconds." to "Timed out waiting for context KV cache transfer after %d milliseconds." to remove request ID and generalize the message.
Test exclusion removal tests/integration/test_lists/waives.txt	Removed SKIP entry for unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out_kv_cache_exhausted, enabling the test to run.
Backend configuration tests/unittest/llmapi/test_llm_pytorch.py	Updated two test cases to use UCX backend for KV cache transfer instead of DEFAULT backend, while maintaining kv_transfer_timeout_ms=1000.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• All changes are straightforward configuration or logging adjustments with no complex logic modifications
• Test backend migration follows a consistent pattern across two test cases
• No behavioral changes to core functionality, only message wording and test configuration

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check	⚠️ Warning	The PR description is largely empty, containing only the template structure with no actual information about the issue, solution, or test coverage filled in.	Fill in the Description section explaining the issue and solution, provide Test Coverage details listing relevant tests, and ensure all required sections are completed with substantive content.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title follows the required format [ticket][type] and clearly describes the main change: fixing a context-only timed-out test related to KV cache functionality.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

♻️ Duplicate comments (1)

tests/unittest/llmapi/test_llm_pytorch.py (1)

1067-1067: Verify UCX backend availability in test environments.

Similar to line 989, this test now explicitly uses the UCX backend. Ensure UCX is available in all test environments, or add appropriate skip conditions.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f95edb5 and eed02da.

📒 Files selected for processing (3)

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp (1 hunks)
• tests/integration/test_lists/waives.txt (0 hunks)
• tests/unittest/llmapi/test_llm_pytorch.py (2 hunks)

💤 Files with no reviewable changes (1)

• tests/integration/test_lists/waives.txt

🧰 Additional context used

🧠 Learnings (10)

📓 Common learnings

Learnt from: fredricz-20070104
Repo: NVIDIA/TensorRT-LLM PR: 7785
File: tests/integration/defs/perf/utils.py:321-333
Timestamp: 2025-09-17T06:01:01.836Z
Learning: In test infrastructure code for disaggregated serving tests, prefer logging errors and continuing execution rather than raising exceptions on timeout, to avoid disrupting test cleanup and causing cascading failures.

📚 Learning: 2025-08-21T09:41:49.347Z

Learnt from: eopXD
Repo: NVIDIA/TensorRT-LLM PR: 6768
File: cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp:2010-2045
Timestamp: 2025-08-21T09:41:49.347Z
Learning: In cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp, updateSequenceCacheBlockOffsets is specifically for updating bookkeeping when blocks are added during the context phase, not for refreshing offsets after detach operations. During detach operations, GenerationRequest::removeFrontBlock handles the necessary cache block bookkeeping internally.

Applied to files:

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

📚 Learning: 2025-08-20T06:56:02.889Z

Learnt from: eopXD
Repo: NVIDIA/TensorRT-LLM PR: 6768
File: cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp:577-579
Timestamp: 2025-08-20T06:56:02.889Z
Learning: In cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp, maxSequenceLength is now enforced as a non-optional argument in the BlockManager constructor, so concerns about std::nullopt defaulting to 0 are not applicable. When windowSize > maxSequenceLength, a warning should be added instead of handling optional parameter cases.

Applied to files:

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

📚 Learning: 2025-08-06T08:18:28.669Z

Learnt from: zhengd-nv
Repo: NVIDIA/TensorRT-LLM PR: 6633
File: cpp/tensorrt_llm/batch_manager/dataTransceiverImpl.cpp:145-155
Timestamp: 2025-08-06T08:18:28.669Z
Learning: In cpp/tensorrt_llm/batch_manager/dataTransceiverImpl.cpp, the existing `mMtxForMap` mutex in DataSenderImpl is sufficient to synchronize measurement file operations in the `release` method, as all file operations occur within the same critical section that protects the `mRequestToSession` map access.

Applied to files:

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

📚 Learning: 2025-08-14T21:04:50.248Z

Learnt from: thorjohnsen
Repo: NVIDIA/TensorRT-LLM PR: 6910
File: cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp:0-0
Timestamp: 2025-08-14T21:04:50.248Z
Learning: In KV cache onboarding logic during prefill in cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp, when calculating which blocks fall within the attention window, use getTokensPerBlock() to advance token indices rather than block->getUniqueTokens().size(), because the calculation needs to consider the post-prefill state where blocks will be filled to capacity, not their current token count.

Applied to files:

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

📚 Learning: 2025-08-20T06:48:45.368Z

Learnt from: eopXD
Repo: NVIDIA/TensorRT-LLM PR: 6768
File: cpp/include/tensorrt_llm/batch_manager/kvCacheManager.h:0-0
Timestamp: 2025-08-20T06:48:45.368Z
Learning: In cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp, updateSequenceCacheBlockOffsets is only called when adding a sequence, not during detach operations. During detach, the cache block bookkeeping is handled by GenerationRequest::removeFrontBlock.

Applied to files:

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

📚 Learning: 2025-08-15T06:46:54.897Z

Learnt from: eopXD
Repo: NVIDIA/TensorRT-LLM PR: 6767
File: cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp:0-0
Timestamp: 2025-08-15T06:46:54.897Z
Learning: In cpp/tensorrt_llm/batch_manager/kvCacheManager.cpp addToken function, newly allocated blocks are unshared by design. The beam search path in addToken (when sequence.getNumTokens() > windowSize) is currently broken/non-functional with SWA, so the block allocation doesn't follow a shared-then-unshared pattern.

Applied to files:

• cpp/tensorrt_llm/batch_manager/cacheTransceiver.cpp

📚 Learning: 2025-07-28T17:06:08.621Z

Learnt from: moraxu
Repo: NVIDIA/TensorRT-LLM PR: 6303
File: tests/integration/test_lists/qa/examples_test_list.txt:494-494
Timestamp: 2025-07-28T17:06:08.621Z
Learning: In TensorRT-LLM testing, it's common to have both CLI flow tests (test_cli_flow.py) and PyTorch API tests (test_llm_api_pytorch.py) for the same model. These serve different purposes: CLI flow tests validate the traditional command-line workflow, while PyTorch API tests validate the newer LLM API backend. Both are legitimate and should coexist.

Applied to files:

• tests/unittest/llmapi/test_llm_pytorch.py

📚 Learning: 2025-08-26T09:37:10.463Z

Learnt from: jiaganc
Repo: NVIDIA/TensorRT-LLM PR: 7031
File: tensorrt_llm/bench/dataclasses/configuration.py:90-104
Timestamp: 2025-08-26T09:37:10.463Z
Learning: In TensorRT-LLM, the `get_pytorch_perf_config()` method returns `self.pytorch_config` which can contain default `cuda_graph_config` values, so `llm_args` may already have this config before the extra options processing.

Applied to files:

• tests/unittest/llmapi/test_llm_pytorch.py

📚 Learning: 2025-08-26T09:37:10.463Z

Learnt from: jiaganc
Repo: NVIDIA/TensorRT-LLM PR: 7031
File: tensorrt_llm/bench/dataclasses/configuration.py:90-104
Timestamp: 2025-08-26T09:37:10.463Z
Learning: In TensorRT-LLM's bench configuration, the `get_pytorch_perf_config()` method returns `self.pytorch_config` which is a Dict[str, Any] that can contain default values including `cuda_graph_config`, making the fallback `llm_args["cuda_graph_config"]` safe to use.

Applied to files:

• tests/unittest/llmapi/test_llm_pytorch.py

🧬 Code graph analysis (1)

tests/unittest/llmapi/test_llm_pytorch.py (3)

tests/unittest/llmapi/apps/_test_openai_chat.py (1)

• backend (26-27)

tests/unittest/llmapi/apps/_test_openai_completions.py (1)

• backend (21-22)

tests/unittest/llmapi/apps/_test_openai_misc.py (1)

• backend (14-15)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

🔇 Additional comments (1)

tests/unittest/llmapi/test_llm_pytorch.py (1)

989-989: Explicitly setting backend="UCX" bypasses environment variable resolution—verify UCX is available in the test environment.

The change from backend="DEFAULT" to backend="UCX" has a different behavior: DEFAULT backend resolves via environment variables (TRTLLM_USE_UCX_KVCACHE, etc.), while explicitly setting backend="UCX" skips this resolution and directly attempts to use UCX. If UCX is unavailable in the test environment (not compiled or not installed), the test will fail at runtime even though the configuration is accepted.

Ensure that:

• The test environment has UCX support compiled and available
• The change is intentional (not masking environment detection issues)
• Consider whether other tests still need DEFAULT backend for environment portability

[tensorrt-cicd]

PR_Github #25567 [ run ] triggered by Bot. Commit: eed02da

[tensorrt-cicd]

PR_Github #25567 [ run ] completed with state SUCCESS. Commit: eed02da
/LLM/main/L0_MergeRequest_PR pipeline #19364 completed with status: 'FAILURE'

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #25758 [ run ] triggered by Bot. Commit: eed02da

[tensorrt-cicd]

PR_Github #25758 [ run ] completed with state SUCCESS. Commit: eed02da
/LLM/main/L0_MergeRequest_PR pipeline #19533 completed with status: 'FAILURE'

[pcastonguay]

@chuangz0 could you please review? When using NIXL as backend, the test shows a seg fault on shutdown, so I switched to UCX for this test.

[pcastonguay]

/bot run --disable-fail-fast

[pcastonguay]

/bot run --disable-fail-fast

[pcastonguay]

/bot kill

[pcastonguay]

/bot run --disable-fail-fast

[tensorrt-cicd]

PR_Github #25886 [ kill ] triggered by Bot. Commit: eed02da

[tensorrt-cicd]

PR_Github #25886 [ kill ] completed with state SUCCESS. Commit: eed02da
Successfully killed previous jobs for commit eed02da

[tensorrt-cicd]

PR_Github #25887 [ run ] triggered by Bot. Commit: eed02da

[tensorrt-cicd]

PR_Github #25887 [ run ] completed with state SUCCESS. Commit: eed02da
/LLM/main/L0_MergeRequest_PR pipeline #19631 completed with status: 'SUCCESS'