Skip to content

Conversation

@galagam
Copy link
Collaborator

@galagam galagam commented Nov 16, 2025

Summary by CodeRabbit

  • New Features
    • Enabled Relu2 activation support in MoE GEMM kernel operations, expanding the available activation functions for mixture-of-experts tensor computations.

Description

Cutlass MoE kernels were integrated in #9011, and FP8 support is already integrated. This PR adds boilerplate code to enable BF16 invocation as well.

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 16, 2025

📝 Walkthrough

Walkthrough

Adds Relu2 activation support to CUTLASS-based operations by introducing a new epilogue operation tag and enabling its dispatch in MoE GEMM kernels, converting previous unsupported error handling to a functional code path.

Changes

Cohort / File(s) Summary
Epilogue infrastructure
cpp/tensorrt_llm/cutlass_extensions/include/cutlass_extensions/epilogue_helpers.h
Added EpilogueOpDefaultRelu2 struct tag and introduced corresponding Epilogue template specialization using LinearCombinationGeneric with Relu2 activation, default scale mode, and nearest rounding enabled.
MoE GEMM kernel dispatch
cpp/tensorrt_llm/kernels/cutlass_kernels/moe_gemm/moe_gemm_template_dispatch.h
Changed ActivationType::Relu2 handling in MoeGemmRunner::moeGemmBiasAct from throwing an unsupported error to dispatching with the new EpilogueOpDefaultRelu2 epilogue operation.

Sequence Diagram

sequenceDiagram
    participant Caller as MoE GEMM Caller
    participant Dispatch as moeGemmBiasAct Dispatch
    participant Epilogue as EpilogueOpDefaultRelu2

    rect rgb(200, 240, 200)
    Note over Caller,Epilogue: Before: Relu2 ActivationType
    Caller->>Dispatch: moeGemmBiasAct(..., ActivationType::Relu2, ...)
    Dispatch->>Dispatch: Check ActivationType::Relu2
    Dispatch-->>Caller: Throw unsupported error ✗
    end

    rect rgb(200, 220, 240)
    Note over Caller,Epilogue: After: Relu2 ActivationType
    Caller->>Dispatch: moeGemmBiasAct(..., ActivationType::Relu2, ...)
    Dispatch->>Dispatch: Check ActivationType::Relu2
    Dispatch->>Epilogue: Dispatch with EpilogueOpDefaultRelu2
    Epilogue->>Epilogue: Apply LinearCombinationGeneric<Relu2>
    Epilogue-->>Caller: Return result ✓
    end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Straightforward additions following existing patterns (new epilogue tag and template specialization)
  • Minimal behavioral impact: converts error path to functional path with single-operation dispatch
  • Limited file scope with cohesive changes related to Relu2 activation support

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description check ❓ Inconclusive PR description is mostly complete with context explaining the purpose (BF16 support for Cutlass MoE kernels), but is missing specific information in Test Coverage section. Provide specific test cases or test plan that verify BF16 invocation works correctly for Cutlass MoE kernels to demonstrate sufficient test coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding ReLU2 activation support to TensorRT-LLM Cutlass MoE BF16 kernels.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide custom instructions to shape the summary (bullet lists, tables, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example:

"Create a concise high-level summary as a bullet-point list. Then include a Markdown table showing lines added and removed by each contributing author."


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@galagam
Copy link
Collaborator Author

galagam commented Nov 16, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24673 [ run ] triggered by Bot. Commit: 22dd0ba

@nzmora-nvidia nzmora-nvidia changed the title [#8732][feat] Support TRTLLM Cutlass MoE BF16 kernels [#8732][feat] Add ReLU2 to TRTLLM Cutlass MoE BF16 kernels Nov 16, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24673 [ run ] completed with state SUCCESS. Commit: 22dd0ba
/LLM/main/L0_MergeRequest_PR pipeline #18629 completed with status: 'FAILURE'

@galagam galagam force-pushed the dev-gagam-relu2-bf16-fix branch from 22dd0ba to 493686f Compare November 17, 2025 14:22
@galagam
Copy link
Collaborator Author

galagam commented Nov 17, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24774 [ run ] triggered by Bot. Commit: 493686f

@nvchenghaoz
Copy link
Collaborator

will this PR fix the #9184?

@galagam galagam enabled auto-merge (squash) November 17, 2025 18:49
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24774 [ run ] completed with state SUCCESS. Commit: 493686f
/LLM/main/L0_MergeRequest_PR pipeline #18691 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@galagam galagam merged commit 5e53008 into NVIDIA:main Nov 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants