Skip to content

Conversation

@rosenrodt
Copy link
Collaborator

@rosenrodt rosenrodt commented Nov 9, 2025

@coderabbitai summary

Description

  • Update more NVFP4 MoE latency & throughput kernels, MXFP4 tileN=256 max throughput kernels by @hummingtree
  • Reduce padding for gpt-oss weight from FC1 [6144, 3072] FC2 [3072, 3072] to FC1 [5888, 3072] FC2 [2944, 3072], and the TMA bound for the weight tensor is set much tigher at [5760, 3072], [2880, 2944], so roughly 7%/13% reduction in bytes during kernel run respectively. The e2e improvement is about 3-5%
  • Filter out kernel candidates during autotune based on token number. Taken from Update trtllm-gen fused moe routing kernel and add more kernels flashinfer-ai/flashinfer#1955
  • Fixed fp8 per tensor MoE w/ non-Llama4 routing @nekorobov
Concurrency vs TPS/user Qwen3-235B-A22B NVFP4 TP1 gpt-oss-120b MXFP4 x MXFP8 TP1
Updated Baseline Speedup Updated Baseline Speedup
1 135.8 135.4 1.00 393.4 391.7 1.00
4 94.6 94.7 1.00 289.7 289.9 1.00
8 77.7 76.9 1.01 240.2 233.7 1.03
16 62.8 62.8 1.00 191.6 185.2 1.03
32 52.3 51.9 1.01 146.0 139.4 1.05
64 43.7 43.7 1.00 115.7 111.4 1.04
128 34.9 35.3 0.99 87.7 84.5 1.04
256 22.0 22.1 1.00 62.7 60.2 1.04
512 12.0 12.2 0.99 41.0 39.1 1.05
1024 6.9 6.8 1.01 21.9 21.6 1.01

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@rosenrodt rosenrodt requested review from a team as code owners November 9, 2025 02:09
@rosenrodt rosenrodt requested review from hyukn and yuxianq November 9, 2025 02:09
@rosenrodt
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23910 [ run ] triggered by Bot. Commit: 98c5c8f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23910 [ run ] completed with state SUCCESS. Commit: 98c5c8f
/LLM/main/L0_MergeRequest_PR pipeline #18001 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23933 [ run ] triggered by Bot. Commit: 639c225

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23933 [ run ] completed with state SUCCESS. Commit: 639c225
/LLM/main/L0_MergeRequest_PR pipeline #18022 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23954 [ run ] triggered by Bot. Commit: 6239cfd

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23954 [ run ] completed with state SUCCESS. Commit: 6239cfd
/LLM/main/L0_MergeRequest_PR pipeline #18038 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

Got issue in CI. Will reivse & rebase and relaunch test

[2025-11-10T05:36:40.921Z] /usr/bin/ld: tests/unit_tests/kernels/CMakeFiles/routingKernelsTest.dir/routing/routingTest.cpp.o: undefined reference to symbol 'PyEval_SaveThread'

[2025-11-10T05:36:40.921Z] /usr/bin/ld: /lib/x86_64-linux-gnu/libpython3.12.so.1.0: error adding symbols: DSO missing from command line

@rosenrodt rosenrodt requested a review from nekorobov November 10, 2025 07:22
@rosenrodt
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24125 [ run ] triggered by Bot. Commit: beb64eb

@rosenrodt
Copy link
Collaborator Author

/bot kill

@rosenrodt rosenrodt force-pushed the tighten-tma-bound branch 2 times, most recently from 5ab887e to 87d4bbf Compare November 11, 2025 08:59
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24151 [ kill ] triggered by Bot. Commit: 87d4bbf

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24125 [ run ] completed with state ABORTED. Commit: beb64eb
LLM/main/L0_MergeRequest_PR #18185 (Blue Ocean) completed with status: ABORTED

@rosenrodt
Copy link
Collaborator Author

/bot run --disable-fail-fast --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24261 [ run ] triggered by Bot. Commit: 1a05966

@rosenrodt rosenrodt force-pushed the tighten-tma-bound branch 2 times, most recently from f475c45 to 6ef09be Compare November 12, 2025 07:32
Signed-off-by: Anthony Chang <[email protected]>
@tensorrt-cicd
Copy link
Collaborator

PR_Github #24261 [ run ] completed with state SUCCESS. Commit: 1a05966
/LLM/main/L0_MergeRequest_PR pipeline #18302 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

/bot run --disable-fail-fast --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24302 [ run ] triggered by Bot. Commit: 44fe756

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24302 [ run ] completed with state SUCCESS. Commit: 44fe756
/LLM/main/L0_MergeRequest_PR pipeline #18334 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24355 [ run ] triggered by Bot. Commit: 44fe756

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24355 [ run ] completed with state SUCCESS. Commit: 44fe756
/LLM/main/L0_MergeRequest_PR pipeline #18381 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24446 [ run ] triggered by Bot. Commit: 44fe756

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24446 [ run ] completed with state SUCCESS. Commit: 44fe756
/LLM/main/L0_MergeRequest_PR pipeline #18443 completed with status: 'FAILURE'

@rosenrodt
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24530 [ run ] triggered by Bot. Commit: 44fe756

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24530 [ run ] completed with state SUCCESS. Commit: 44fe756
/LLM/main/L0_MergeRequest_PR pipeline #18515 completed with status: 'SUCCESS'

@byshiue byshiue merged commit 86cfb3e into NVIDIA:main Nov 17, 2025
7 checks passed
niukuo added a commit that referenced this pull request Nov 17, 2025
…dding requirement; tighten TMA bound (#9025)"

This reverts commit 86cfb3e.
greg-kwasniewski1 pushed a commit to nv-auto-deploy/TensorRT-LLM that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants