Skip to content

Conversation

@tanmayv25
Copy link

@tanmayv25 tanmayv25 commented Oct 30, 2025

Summary by CodeRabbit

  • Chores
    • Optimized build configuration to generate release builds, enabling improved application performance and reduced artifact size.

Description

The install_nixl.sh script seems to be building and installing debug version. This PR adds the option to build release version of NIXL.
See here for more info: https://github.com/ai-dynamo/nixl?tab=readme-ov-file#build-options

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@tanmayv25 tanmayv25 requested review from a team as code owners October 30, 2025 23:05
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

📝 Walkthrough

Walkthrough

Adds the Meson build option --buildtype=release to the nixl build step in the Docker installation script to produce a release build instead of the default debug build.

Changes

Cohort / File(s) Summary
Build optimization
docker/common/install_nixl.sh
Added --buildtype=release Meson build flag to the nixl build invocation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify that --buildtype=release is the appropriate build type for the production Docker environment
  • Confirm no performance or compatibility regressions are introduced by the release build configuration

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description provides a clear and substantive explanation of the change in the Description section, explaining that the script currently builds a debug version and this PR adds the option to build a release version, with a relevant documentation link. However, the description is missing or incompletely formatted in several required sections: the PR title is not explicitly provided in the required format [ticket/issue/None][type] Summary, the Test Coverage section is entirely empty with no test information listed, and the PR Checklist items remain unchecked without confirmation. While the core descriptive content is present and adequate, the overall submission significantly deviates from the template structure by omitting required sections. The PR description needs to be completed to meet template requirements. Add a properly formatted title following [None][type] Summary format (e.g., [None][infra] Change NIXL build type to release). Fill in the Test Coverage section with information about which tests safeguard this change, or explain why no tests are applicable. Review and check off the appropriate items in the PR Checklist to confirm they were addressed. Once these required sections are completed or explicitly addressed, the description will be compliant with the repository template.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None] Change NIXL build type to release" clearly and specifically describes the main change in the PR: modifying the NIXL build configuration to use a release build type instead of the default debug version. The title is concise, avoids vague terminology, and directly relates to the change summarized in the raw file modifications. It appropriately highlights the primary objective from the developer's perspective without extraneous details.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Oct 30, 2025
@karljang
Copy link
Collaborator

karljang commented Nov 5, 2025

@tanmayv25 , thanks for your contribution!
Before we move forward, could you please address the failed checks above?
Also, please refer to Signing Your Work for guidance on DCO and code signing.

@Shixiaowei02
Copy link
Collaborator

Thanks for your contribution!

-Dgds_path="$GDS_PATH" \
-Dinstall_headers=true
-Dinstall_headers=true \
--buildtype=release
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change.
Please Note that when building NIXL in release mode, we should also set the plugins path.

For example:

export NIXL_PLUGIN_DIR=/opt/nvidia/nvda_nixl/lib/x86_64-linux-gnu/plugins

@Shixiaowei02
Copy link
Collaborator

This PR has been integrated into #9225 . Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community want to contribute PRs initiated from Community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants