Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Oct 29, 2025

Summary by CodeRabbit

  • Tests
    • Updated test suite configurations to skip additional test cases, including performance benchmarks and accuracy validations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

📝 Walkthrough

Walkthrough

This pull request adds multiple SKIP entries to the test waives list, marking additional test cases as skipped. The additions include performance benchmarks from llama v3.1 configurations, triton server unit tests, and disaggregated serving accuracy tests. No existing entries are modified, and no logic changes are introduced.

Changes

Cohort / File(s) Change Summary
Test Waives Configuration
tests/integration/test_lists/waives.txt
Appends multiple SKIP entries for performance benchmarks (various llama v3.1 configurations), triton server unit tests, and disaggregated serving accuracy test cases. Extends the existing waive list without modifying prior entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that each added SKIP entry corresponds to an actual test case that requires waiving
  • Confirm the specific test identifiers and configurations (e.g., llama v3.1 variants, triton configurations) are accurate
  • Check for any duplicate entries across the new additions

Possibly related PRs

Suggested reviewers

  • ZhanruiSunCh
  • yiqingy0
  • niukuo
  • chzblych

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description is largely incomplete and consists primarily of the template scaffolding without substantive content. While a PR title is referenced in the PR objectives ("[None][infra] Waive failed tests on main"), the actual PR description submitted is just the template itself with empty placeholder sections. The "Description" section contains only comments and no explanation of the changes, the "Test Coverage" section is similarly empty, and most items in the PR Checklist are unchecked. The author has not filled in the required sections explaining what was changed, why these tests are being waived, or what test coverage validates these changes. The author should fill out the PR description template with: (1) a clear explanation of why specific tests are being waived and what the business justification is, (2) a Test Coverage section explaining which test lists or scenarios are being modified and why, and (3) appropriate checklist items checked off or marked as not applicable. At minimum, the Description and Test Coverage sections must be substantively completed to explain the purpose and scope of the test waiver changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None][infra] Waive failed tests on main" follows the required format with a valid ticket identifier, type classification, and summary. The title directly relates to the main change in the pull request, which is adding SKIP entries to the waives.txt file to waive failed tests. The title is concise, clear, and accurately communicates the primary purpose of the changeset without unnecessary verbosity.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Just skip failed cases"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22894 [ skip ] triggered by Bot. Commit: 8ebe3e7

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) October 29, 2025 13:01
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22894 [ skip ] completed with state SUCCESS. Commit: 8ebe3e7
Skipping testing for commit 8ebe3e7

@EmmaQiaoCh EmmaQiaoCh merged commit 579e106 into NVIDIA:main Oct 29, 2025
8 of 9 checks passed
@chzblych chzblych changed the title [None][infra] Waive failed tests on main [None][infra] Waive failed tests on main 10/29 Oct 29, 2025
fredricz-20070104 pushed a commit to fredricz-20070104/TensorRT-LLM that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants