Skip to content

Conversation

@liji-nv
Copy link
Collaborator

@liji-nv liji-nv commented Oct 29, 2025

Summary by CodeRabbit

  • Tests
    • Re-enabled previously skipped integration tests to expand test coverage for auto dtype configuration and n-gram functionality in model serving scenarios.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@liji-nv liji-nv requested a review from a team as a code owner October 29, 2025 10:05
@liji-nv
Copy link
Collaborator Author

liji-nv commented Oct 29, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 29, 2025

📝 Walkthrough

Walkthrough

Test configuration changes enabling previously skipped tests. A skip decorator is removed from the test_ngram method, and three corresponding skip entries are removed from the test waiver list.

Changes

Cohort / File(s) Summary
Test Skip Decorator Removal
tests/integration/defs/accuracy/test_disaggregated_serving.py
Removed @skip_pre_hopper decorator from test_ngram method, enabling the test to execute.
Test Waiver List Updates
tests/integration/test_lists/waives.txt
Removed three SKIP entries: test_auto_dtype[False], test_auto_dtype[True], and test_ngram from the Llama3_1_8BInstruct test class.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The PR description provided is largely a template copy with critical sections left empty and incomplete. While the PR title appears to follow the correct format (based on the objectives showing "[https://nvbugs/5488118][fix] Unwaive passed tests"), the Description and Test Coverage sections contain only template placeholders with no substantive content explaining what changes are being made or why. The PR Checklist shows most items unchecked, indicating the author did not complete the required pre-submission review. Based on the raw summary showing test decorator removals and waive list changes, the author should have explained the rationale and test impact but failed to do so in the provided description.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[https://nvbugs/5488118][fix] Unwaive passed tests" is directly related to the main changes in the pull request. The raw_summary shows that the PR removes the @skip_pre_hopper decorator from the test_ngram method and removes three SKIP entries from the waives test list. The title accurately and concisely describes this primary objective of removing test waivers for tests that are now passing. The title follows the correct format specified in the template with a valid NVBugs ID, type indicator [fix], and a clear summary statement.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22880 [ run ] triggered by Bot. Commit: fb4516a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22880 [ run ] completed with state SUCCESS. Commit: fb4516a
/LLM/release-1.1/L0_MergeRequest_PR pipeline #303 completed with status: 'FAILURE'

@liji-nv
Copy link
Collaborator Author

liji-nv commented Oct 30, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22989 [ run ] triggered by Bot. Commit: fb4516a

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22989 [ run ] completed with state SUCCESS. Commit: fb4516a
/LLM/release-1.1/L0_MergeRequest_PR pipeline #317 completed with status: 'SUCCESS'

@liji-nv liji-nv merged commit 28673f3 into NVIDIA:release/1.1 Oct 31, 2025
8 of 9 checks passed
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 4, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 4, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 4, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 5, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 6, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 6, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 10, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 12, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 14, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 17, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 18, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 19, 2025
mikeiovine pushed a commit to mikeiovine/TensorRT-LLM that referenced this pull request Nov 19, 2025
Signed-off-by: Jin Li <[email protected]>
Signed-off-by: Mike Iovine <[email protected]>
Signed-off-by: Mike Iovine <[email protected]>
mikeiovine pushed a commit that referenced this pull request Nov 20, 2025
Signed-off-by: Jin Li <[email protected]>
Signed-off-by: Mike Iovine <[email protected]>
Signed-off-by: Mike Iovine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants