Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Oct 24, 2025

Summary by CodeRabbit

  • Tests
    • Updated test exclusion configuration to adjust coverage for various accuracy and integration test suites.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2025

📝 Walkthrough

Walkthrough

Modified test waiver file to exclude specific accuracy and CLI flow tests. Removed multiple SKIP entries and added new ones for failing tests, including entries for GPT OS, Qwen models, and Triton server tests.

Changes

Cohort / File(s) Summary
Test Skip Entries
tests/integration/test_lists/waives.txt
Removed SKIP entries for fp8 rowwise tp4, cp2, tp2, tp4, fp8 tp2pp2 manage weights, and related variants; added new SKIP entries for test_w4_1gpu (fp8), test_bf16 (multi_gpus_no_cache), and test_llava (llava)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • yiqingy0
  • chzblych
  • ZhanruiSunCh
  • niukuo

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description is largely incomplete and consists primarily of the repository's PR template with empty placeholder sections. While the PR objectives indicate an actual title exists on GitHub ("[None][Infra] Waive tests on main and remove lines which missed in MI"), the provided description contains no content for the critical "Description" section, which should explain the issue and solution. The "Test Coverage" section is also entirely empty, providing no information about which tests safeguard the changes. The PR Checklist is marked as complete with a single checkbox, but this appears to be a formality without substantive engagement with the individual checklist items. The raw summary indicates changes to a waives configuration file, but this context is not reflected in or explained by the description itself. The author should fill out the Description section to explain what test waives are being modified and why, provide a list of relevant tests in the Test Coverage section, and ensure the PR Checklist items are individually addressed with substantive comments or confirmations. The actual PR title from GitHub should also be included at the top of the description to match the template requirements. These additions will ensure reviewers understand the purpose and scope of the changes.
Title Check ❓ Inconclusive The title "[None][infra] Waive tests on main and remove lines which missed in MI" does follow the required format with a ticket designation and type tag. It is partially related to the changeset, which involves modifying the waives.txt file by removing some SKIP entries and adding new ones. The term "waive tests" accurately reflects part of the change, but the phrase "remove lines which missed in MI" is vague and unclear—it does not clearly explain what "MI" refers to or provide sufficient context about the actual scope of changes. This lack of clarity in phrasing diminishes the title's ability to clearly communicate the primary intent of the changeset to teammates reviewing the commit history.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Only update waive files"

@EmmaQiaoCh EmmaQiaoCh changed the title [None][Infra] Waive tests on main and remove lines which missed in MI [None][infra] Waive tests on main and remove lines which missed in MI Oct 24, 2025
@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) October 24, 2025 06:20
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22391 [ skip ] triggered by Bot. Commit: cde691d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22391 [ skip ] completed with state SUCCESS. Commit: cde691d
Skipping testing for commit cde691d

@EmmaQiaoCh EmmaQiaoCh merged commit 35e35db into NVIDIA:main Oct 24, 2025
8 of 11 checks passed
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants