Skip to content

Conversation

@EmmaQiaoCh
Copy link
Collaborator

@EmmaQiaoCh EmmaQiaoCh commented Oct 23, 2025

Summary by CodeRabbit

  • Chores
    • Temporarily disabled GPU test configurations due to offline hardware nodes. RTXPro6000 post-merge tests are excluded from the testing pipeline until the nodes are restored.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

Signed-off-by: qqiao <qqiao@nvidia.com>
@EmmaQiaoCh EmmaQiaoCh requested a review from a team as a code owner October 23, 2025 06:31
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 23, 2025

📝 Walkthrough

Walkthrough

The change removes three RTXPro6000 test configurations from the x86 test set and replaces them with inline comments indicating that these stages are disabled due to temporary node unavailability. The modification excludes specific RTXPro6000 test stages without altering surrounding test logic.

Changes

Cohort / File(s) Change Summary
RTXPro6000 Test Configuration Removal
jenkins/L0_Test.groovy
Removes three RTXPro6000-based test stage configurations (RTXPro6000-PyTorch-Post-Merge-1, RTXPro6000-4_GPUs-PyTorch-Post-Merge-1, RTXPro6000-4_GPUs-PyTorch-Post-Merge-2) from the x86 test set and replaces them with comments explaining the stages are disabled due to offline nodes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description does not meet the requirements specified in the template. While the author has included the template structure, the critical sections are not filled out: the PR title is missing entirely (only template guidance is shown), the Description section is empty with no explanation of the issue or solution, and the Test Coverage section is empty with no test cases listed. Most items in the PR Checklist remain unchecked, indicating the author has not reviewed the required verification steps. The GitHub Bot Help documentation is supplementary and does not substitute for the core PR description requirements. The only completed element is the final checklist item. The author should provide a proper PR title following the format [None][infra] Disable rtxpro6000 stages due to nodes being offline temporarily, write a brief Description explaining why the RTXPro6000 stages are being disabled and how the change accomplishes this, list relevant test coverage information (or explain why no new tests are needed for this infrastructure change), and review the PR Checklist items to ensure all applicable items are verified and checked. The PR should not be merged until these sections are properly completed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The PR title "[None][infra] Disable rtxpro6000 stages due to nodes will be offline temporarily" directly and accurately reflects the main change described in the code summary. The title clearly indicates that RTXPro6000 test stages are being disabled due to temporary node unavailability, which matches the changeset that removes three RTXPro6000 test configurations and replaces them with comments. The title follows the repository's template format correctly and is specific and concise enough for scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
jenkins/L0_Test.groovy (1)

2120-2123: Add a tracking ticket reference for re-enablement.

The comment indicates this is a temporary change, but there's no tracking mechanism to ensure these stages are re-enabled when the nodes come back online. Consider adding:

  • A reference to a tracking ticket/issue (e.g., "See issue #XXXX")
  • Expected timeline or conditions for re-enablement

Apply this diff to improve traceability:

-        // Disable RTXPro6000 stages due to nodes will be offline temporarily
+        // TODO(#TICKET): Re-enable RTXPro6000 stages once nodes are back online
+        // Disable RTXPro6000 stages due to nodes will be offline temporarily
         // "RTXPro6000-PyTorch-Post-Merge-1": ["rtx-pro-6000", "l0_rtx_pro_6000", 1, 1],
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4e1cc7 and 0b7c9dc.

📒 Files selected for processing (1)
  • jenkins/L0_Test.groovy (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

@EmmaQiaoCh
Copy link
Collaborator Author

/bot skip --comment "Just comment out rtxpro-6000 stages"

@EmmaQiaoCh EmmaQiaoCh enabled auto-merge (squash) October 23, 2025 13:51
@tensorrt-cicd
Copy link
Collaborator

PR_Github #22296 [ skip ] triggered by Bot. Commit: 0b7c9dc

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22296 [ skip ] completed with state SUCCESS. Commit: 0b7c9dc
Skipping testing for commit 0b7c9dc

@EmmaQiaoCh EmmaQiaoCh merged commit 4e11e0b into NVIDIA:release/1.1 Oct 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants