[https://nvbugs/5549081][fix] Fix device id assignment for some visio…

[chang-l]

cherry-pick from #8070

Summary by CodeRabbit

• Refactor
  • Updated device initialization logic across model implementations to use current CUDA device selection instead of rank-based assignment, with planned migration to local rank configuration in future updates.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[chang-l]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

Device selection logic is being updated across three model files. The change replaces device assignment from using model_config.mapping.rank to torch.cuda.current_device(), with TODO comments indicating a potential future switch to config.mapping.get_local_rank(). No control flow or error handling is modified.

Changes

Cohort / File(s)	Summary
Model device selection refactor tensorrt_llm/_torch/models/modeling_hyperclovax.py, tensorrt_llm/_torch/models/modeling_llama.py, tensorrt_llm/_torch/models/modeling_llava_next.py	Replaced device selection from model_config.mapping.rank to torch.cuda.current_device() with TODO comments suggesting future migration to get_local_rank(). Changes applied across model initialization constructors.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	⚠️ Warning	The PR description is substantially incomplete and consists primarily of template comments without substantive content. While the author mentions this is a cherry-pick from PR #8070, the critical sections are unfilled: the Description section lacks any explanation of the issue or solution, the Test Coverage section is empty, and the PR title is missing in favor of a placeholder for "@coderabbitai summary". The PR Checklist is present but remains largely unchecked. According to the repository's template requirements, the description should clearly explain what and why changes are being made, identify relevant tests, and confirm adherence to coding guidelines, none of which are addressed in the provided description.	Complete the PR description by providing: (1) a properly formatted PR title following the [TICKET][TYPE] Summary pattern with the appropriate NVBugs ID or ticket reference, (2) a Description section explaining what device assignment changes are being made and why they are necessary, (3) a Test Coverage section listing specific tests that validate the device selection behavior across single-GPU and multi-GPU scenarios, and (4) verification and marking of the PR Checklist items to confirm the changes follow coding guidelines and have appropriate test coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[https://nvbugs/5549081][fix] Fix device id assignment for some visio..." clearly relates to the actual changes in the pull request. The summary shows modifications across multiple vision model files (modeling_hyperclovax.py, modeling_llama.py, modeling_llava_next.py) where device selection logic is being updated from using model_config.mapping.rank to using torch.cuda.current_device(). The title accurately conveys that this is a device ID assignment fix for vision models, which matches the core purpose of the changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[tensorrt-cicd]

PR_Github #22090 [ run ] triggered by Bot. Commit: ab258e8

[tensorrt-cicd]

PR_Github #22090 [ run ] completed with state FAILURE. Commit: ab258e8
/LLM/release-1.1/L0_MergeRequest_PR pipeline #220 completed with status: 'FAILURE'

[chang-l]

/bot run

[tensorrt-cicd]

PR_Github #22197 [ run ] triggered by Bot. Commit: ab258e8

[tensorrt-cicd]

PR_Github #22197 [ run ] completed with state SUCCESS. Commit: ab258e8
/LLM/release-1.1/L0_MergeRequest_PR pipeline #231 completed with status: 'FAILURE'

[chang-l]

/bot run

[tensorrt-cicd]

PR_Github #22217 [ run ] triggered by Bot. Commit: ab258e8

[tensorrt-cicd]

PR_Github #22217 [ run ] completed with state SUCCESS. Commit: ab258e8
/LLM/release-1.1/L0_MergeRequest_PR pipeline #232 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.