[https://nvbugs/5569534][fix] Warm up with different sizes for more s…

[liji-nv]

…table perf

Summary by CodeRabbit

• New Features

  • Expanded model warmup process to cover more token-context size combinations for improved initialization coverage.

• Improvements

  • Simplified warmup-related logging for better clarity.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[liji-nv]

/bot run

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request expands the warmup request generation in the torch executor's model engine by computing up to 20 additional token-context size combinations and unioning them into the existing warmup set. A minor comment adjustment accompanies the change without altering control flow.

Changes

Cohort / File(s)	Summary
Warmup request expansion tensorrt_llm/_torch/pyexecutor/model_engine.py	Adds computation of additional token combinations to enrich the warmup request set; includes minor comment/logging adjustments

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Description Check	⚠️ Warning	The PR description is incomplete and fails to meet the template requirements. While the description contains the template structure with sections for "Description" and "Test Coverage," both critical sections are left entirely empty with only placeholder comments. The author has not provided any explanation of the issue being addressed or the solution implemented. Additionally, the "Test Coverage" section contains no information about relevant tests that safeguard the changes. Only the final checkbox in the PR Checklist is marked, but the preceding checklist items that should verify code quality, guidelines adherence, and testing are not meaningfully addressed or completed.	The author should fill in the "Description" section with a clear explanation of what issue the PR addresses and how the warmup expansion improves performance. The "Test Coverage" section must list the specific tests that validate the new warmup combinations. The PR Checklist items should be reviewed and marked appropriately with verification that the changes follow TRT-LLM coding guidelines, include adequate test coverage, and update documentation as needed.
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The PR title "[https://nvbugs/5569534][fix] Warm up with different sizes for more s…" follows the correct format specified in the template, with a valid NVBugs ID, the [fix] type indicator, and a summary statement. The visible portion of the title "Warm up with different sizes" clearly relates to the main change described in the raw summary: adding additional warmup requests with up to 20 different token-context size combinations to expand the warmup surface. Despite the title appearing truncated in display, the core message is specific and directly aligned with the actual changeset.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

tensorrt_llm/_torch/pyexecutor/model_engine.py (2)

660-664: Clarify the comment about the number of warmup requests.

The comment states "Up to 20 warmup requests", but the code creates up to ids - 1 warmup requests (typically 19 when ids = 20). Since range(1, ids) excludes the upper bound, and given that ids = curr_max_num_tokens // step, the actual number of additional warmup requests is ids - 1, not ids.

Consider updating the comment to be more accurate:

-# Up to 20 warmup requests.
+# Add intermediate warmup requests at step intervals (up to ~19 additional requests).

Or adjust the code if exactly 20 additional requests are intended:

-warmup_requests |= set([(id * step, 0) for id in range(1, ids)])
+warmup_requests |= set([(id * step, 0) for id in range(1, min(ids, 20) + 1) if id * step < curr_max_num_tokens])

---

818-822: Fix grammatical error in comment.

Line 819 contains a grammatical error.

Apply this diff to fix the grammar:

-# The cudagraph and piecewise cuda graph capture calls torch.cuda.empty_cache() and block may already
-# be freed even we calls general_warmup for torch compile.
+# The cudagraph and piecewise cuda graph capture call torch.cuda.empty_cache() and blocks may already
+# be freed even though we call general_warmup for torch compile.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ce2dc5 and 2860145.

📒 Files selected for processing (1)

• tensorrt_llm/_torch/pyexecutor/model_engine.py (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

• tensorrt_llm/_torch/pyexecutor/model_engine.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

• tensorrt_llm/_torch/pyexecutor/model_engine.py

**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

• tensorrt_llm/_torch/pyexecutor/model_engine.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

[tensorrt-cicd]

PR_Github #21985 [ run ] triggered by Bot. Commit: 2860145

[tensorrt-cicd]

PR_Github #21985 [ run ] completed with state SUCCESS. Commit: 2860145
/LLM/release-1.1/L0_MergeRequest_PR pipeline #206 completed with status: 'FAILURE'

[hyukn]

LGTM. Thanks a lot! We should find a more convenient way to define the shape constraints for the inputs.

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22244 [ run ] triggered by Bot. Commit: 8180693

[tensorrt-cicd]

PR_Github #22244 [ run ] completed with state SUCCESS. Commit: 8180693
/LLM/release-1.1/L0_MergeRequest_PR pipeline #235 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22288 [ run ] triggered by Bot. Commit: 8180693

[tensorrt-cicd]

PR_Github #22288 [ run ] completed with state SUCCESS. Commit: 8180693
/LLM/release-1.1/L0_MergeRequest_PR pipeline #241 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22406 [ run ] triggered by Bot. Commit: 335d5b9

[tensorrt-cicd]

PR_Github #22406 [ run ] completed with state SUCCESS. Commit: 335d5b9
/LLM/release-1.1/L0_MergeRequest_PR pipeline #254 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22561 [ run ] triggered by Bot. Commit: 335d5b9

[tensorrt-cicd]

PR_Github #22561 [ run ] completed with state SUCCESS. Commit: 335d5b9
/LLM/release-1.1/L0_MergeRequest_PR pipeline #264 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22621 [ run ] triggered by Bot. Commit: f3a50bd

[tensorrt-cicd]

PR_Github #22621 [ run ] completed with state SUCCESS. Commit: f3a50bd
/LLM/release-1.1/L0_MergeRequest_PR pipeline #271 completed with status: 'FAILURE'

[tensorrt-cicd]

PR_Github #22837 [ run ] triggered by Bot. Commit: a0fe59b

[tensorrt-cicd]

PR_Github #22837 [ run ] completed with state SUCCESS. Commit: a0fe59b
/LLM/release-1.1/L0_MergeRequest_PR pipeline #297 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22872 [ run ] triggered by Bot. Commit: a0fe59b

[tensorrt-cicd]

PR_Github #22872 [ run ] completed with state FAILURE. Commit: a0fe59b
/LLM/release-1.1/L0_MergeRequest_PR pipeline #302 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22888 [ run ] triggered by Bot. Commit: a0fe59b

[tensorrt-cicd]

PR_Github #22888 [ run ] completed with state SUCCESS. Commit: a0fe59b
/LLM/release-1.1/L0_MergeRequest_PR pipeline #304 completed with status: 'FAILURE'

[liji-nv]

/bot run

[tensorrt-cicd]

PR_Github #22970 [ run ] triggered by Bot. Commit: a0fe59b

[tensorrt-cicd]

PR_Github #22970 [ run ] completed with state SUCCESS. Commit: a0fe59b
/LLM/release-1.1/L0_MergeRequest_PR pipeline #315 completed with status: 'SUCCESS'