Skip to content

Conversation

@achartier
Copy link
Collaborator

@achartier achartier commented Oct 18, 2025

Summary by CodeRabbit

  • Chores
    • Removed cuFile GPU Direct Storage integration from build configuration and runtime dependencies.

Description

GDS support was added in #3209 but was incomplete. Later, #5488 added a correct implementation over NIXL. This PR removes the extra code from the original PR that is no longer needed.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@achartier achartier requested a review from Funatiq October 18, 2025 21:13
@achartier
Copy link
Collaborator Author

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 18, 2025

📝 Walkthrough

Walkthrough

The changes remove cuFile (CUFILE) integration from the TensorRT-LLM build system and runtime code. This includes eliminating cuFile library discovery and linkage directives from CMake configuration files and removing cuFile header includes from kvCacheTransferManager.cpp.

Changes

Cohort / File(s) Summary
cuFile integration removal
cpp/tensorrt_llm/CMakeLists.txt, cpp/tensorrt_llm/batch_manager/CMakeLists.txt, cpp/tensorrt_llm/batch_manager/kvCacheTransferManager.cpp
Removed cuFile library discovery, conditional ENABLE_CUFILE logic, target linkage directives, and header includes (cufile.h and related POSIX headers) across CMake and source files. No behavioral changes to remaining code paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "[None][chore] Cleanup GDS code" follows the correct template format with a valid ticket identifier (None), appropriate type (chore), and a clear, concise summary. The title accurately reflects the main objective of the changeset—removing legacy GDS/CUFILE integration code that was superseded by a better implementation in PR #5488. The title is specific and descriptive enough to convey the primary change without vagueness or unnecessary details.
Description Check ✅ Passed The pull request description includes all required sections from the template: a clear Description section explaining that GDS support from PR #3209 was incomplete and later superseded by a correct implementation in PR #5488, a Test Coverage section marked as N/A (appropriate for cleanup work), and a completed PR Checklist with items reviewed. The description provides meaningful context by referencing the specific PRs involved and clearly stating the reason for the removal, making it easy for reviewers to understand the intent and justification for the changes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41169fb and 82ade5e.

📒 Files selected for processing (3)
  • cpp/tensorrt_llm/CMakeLists.txt (0 hunks)
  • cpp/tensorrt_llm/batch_manager/CMakeLists.txt (0 hunks)
  • cpp/tensorrt_llm/batch_manager/kvCacheTransferManager.cpp (0 hunks)
💤 Files with no reviewable changes (3)
  • cpp/tensorrt_llm/CMakeLists.txt
  • cpp/tensorrt_llm/batch_manager/CMakeLists.txt
  • cpp/tensorrt_llm/batch_manager/kvCacheTransferManager.cpp
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21775 [ run ] triggered by Bot. Commit: 82ade5e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21775 [ run ] completed with state SUCCESS. Commit: 82ade5e
/LLM/main/L0_MergeRequest_PR pipeline #16413 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21779 [ run ] triggered by Bot. Commit: 82ade5e

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21779 [ run ] completed with state SUCCESS. Commit: 82ade5e
/LLM/main/L0_MergeRequest_PR pipeline #16417 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21916 [ run ] triggered by Bot. Commit: 1131b68

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21916 [ run ] completed with state SUCCESS. Commit: 1131b68
/LLM/main/L0_MergeRequest_PR pipeline #16521 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22095 [ run ] triggered by Bot. Commit: ee7b25d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22095 [ run ] completed with state SUCCESS. Commit: ee7b25d
/LLM/main/L0_MergeRequest_PR pipeline #16659 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22193 [ run ] triggered by Bot. Commit: ee7b25d

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22193 [ run ] completed with state SUCCESS. Commit: ee7b25d
/LLM/main/L0_MergeRequest_PR pipeline #16733 completed with status: 'FAILURE'

Signed-off-by: Aurelien Chartier <[email protected]>
@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22216 [ run ] triggered by Bot. Commit: 6fe089f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22216 [ run ] completed with state SUCCESS. Commit: 6fe089f
/LLM/main/L0_MergeRequest_PR pipeline #16752 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22300 [ run ] triggered by Bot. Commit: 6fe089f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22300 [ run ] completed with state SUCCESS. Commit: 6fe089f
/LLM/main/L0_MergeRequest_PR pipeline #16811 completed with status: 'FAILURE'

@achartier
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22310 [ run ] triggered by Bot. Commit: 6fe089f

@tensorrt-cicd
Copy link
Collaborator

PR_Github #22310 [ run ] completed with state SUCCESS. Commit: 6fe089f
/LLM/main/L0_MergeRequest_PR pipeline #16820 completed with status: 'SUCCESS'

@achartier achartier merged commit 32e1ad6 into NVIDIA:main Oct 23, 2025
5 checks passed
@achartier achartier deleted the clean-gds branch October 23, 2025 19:36
yufeiwu-nv pushed a commit to yufeiwu-nv/TensorRT-LLM that referenced this pull request Oct 24, 2025
Signed-off-by: Aurelien Chartier <[email protected]>
Signed-off-by: yufeiwu-nv <[email protected]>
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants