[https://nvbugs/5558167][fix] update canceled_req_ids correctly for canceled requests

[QiJune]

Summary by CodeRabbit

• Bug Fixes
  • Improved request cancellation handling to properly clear canceled IDs after completion, preventing repeated re-checks and reducing the chance of stalls or unintended behavior during decoding.
  • Enhances stability and performance when canceling in-progress requests by ensuring cleaner post-cancel state and reduced overhead.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adjusts cancellation handling in PyExecutor: after marking a request as finished and updating decoding_iter, the request id is removed from the executor’s canceled request set to prevent future cancel checks from re-detecting it.

Changes

Cohort / File(s)	Summary of Changes
Cancellation cleanup in PyExecutor tensorrt_llm/_torch/pyexecutor/py_executor.py	After handling a canceled request (mark finished, update decoding_iter), immediately removes the request id from executor_request_queue.canceled_req_ids to finalize cleanup.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant Executor
  participant RequestQueue as ReqQueue
  participant Decoder

  Client->>ReqQueue: Cancel(requestId)
  Note right of ReqQueue: requestId added to canceled_req_ids

  Executor->>ReqQueue: Check request state
  alt requestId in canceled_req_ids
    Executor->>Executor: Mark request finished
    Executor->>Decoder: Update decoding_iter
    Executor->>ReqQueue: Remove requestId from canceled_req_ids
    Note over Executor,ReqQueue: Cleanup prevents future cancel re-detection
  else not canceled
    Executor->>Decoder: Proceed with decoding
  end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	⚠️ Warning	The pull request description contains only the unedited template sections and lacks any explanation of the issue, the implemented solution, or relevant test coverage details, so it does not provide the required information for reviewers to understand or validate the changes.	Please remove the placeholder comments and fill in the “Description” section with a clear summary of the problem and the fix, then list specific tests under “Test Coverage” to demonstrate how the changes are validated.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title follows the repository’s template by including a valid NVBugs ID and the “[fix]” type and succinctly summarizes the core change of updating canceled_req_ids for canceled requests, so it accurately reflects the main change without unnecessary detail.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[QiJune]

/bot run

[tensorrt-cicd]

PR_Github #20831 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20831 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15751 completed with status: 'FAILURE'

[QiJune]

/bot run

[tensorrt-cicd]

PR_Github #20841 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20841 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15760 completed with status: 'FAILURE'

[karljang]

/bot run

[tensorrt-cicd]

PR_Github #20855 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20855 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15772 completed with status: 'FAILURE'

[QiJune]

/bot run

[tensorrt-cicd]

PR_Github #20880 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20880 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15794 completed with status: 'FAILURE'

[QiJune]

/bot run

[tensorrt-cicd]

PR_Github #20933 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20933 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15834 completed with status: 'FAILURE'

[QiJune]

/bot run

[tensorrt-cicd]

PR_Github #20975 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #20975 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15862 completed with status: 'SUCCESS'