Skip to content

Conversation

@lucaslie
Copy link
Member

@lucaslie lucaslie commented Oct 3, 2025

Summary by CodeRabbit

  • Tests
    • Parameterized AutoDeploy LLM accuracy test to run across multiple deployment scales.
    • Updated test matrix to target specific configurations on H100/H200 and exclude certain DGX B200 runs for relevance.
    • Added/updated pre- and post-merge entries for PyTorch and TensorRT variants to validate scalability.
    • Improves coverage and reliability across heterogeneous environments without impacting runtime features.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@lucaslie
Copy link
Member Author

lucaslie commented Oct 3, 2025

/bot run

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 3, 2025

📝 Walkthrough

Walkthrough

Parameterizes TestLlama3_1_8B.test_auto_dtype over world_size values [1, 2, 4] and passes world_size into AutoDeployLLM. Updates multiple test list YAMLs to reference specific parameterized variants, adding, changing, or removing entries per environment.

Changes

Cohort / File(s) Summary of Changes
Parametrized test implementation
tests/integration/defs/accuracy/test_llm_api_autodeploy.py
Converted test_auto_dtype to pytest-parametrized over world_size=[1,2,4]; test signature updated to include world_size; AutoDeployLLM called with world_size argument.
Test selection configs
tests/integration/test_lists/test-db/l0_b200.yml, tests/integration/test_lists/test-db/l0_dgx_b200.yml, tests/integration/test_lists/test-db/l0_dgx_h100.yml, tests/integration/test_lists/test-db/l0_dgx_h200.yml, tests/integration/test_lists/test-db/l0_h100.yml
Adjusted test entries to select specific parameterized variants: added [1] in l0_b200 and l0_h100; removed generic and one DGX b200 entry; set [2] in l0_dgx_h100; set [4] for PyTorch and TRT in l0_dgx_h200.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as PyTest Runner
  participant T as test_auto_dtype (parametrized)
  participant LLM as AutoDeployLLM

  Dev->>T: Discover test_auto_dtype[1], [2], [4]
  rect rgba(230,240,255,0.6)
    note right of Dev: Iteration 1
    Dev->>T: Execute with world_size=1
    T->>LLM: Initialize(world_size=1)
    LLM-->>T: Deployment initialized
  end
  rect rgba(230,240,255,0.6)
    note right of Dev: Iteration 2
    Dev->>T: Execute with world_size=2
    T->>LLM: Initialize(world_size=2)
    LLM-->>T: Deployment initialized
  end
  rect rgba(230,240,255,0.6)
    note right of Dev: Iteration 3
    Dev->>T: Execute with world_size=4
    T->>LLM: Initialize(world_size=4)
    LLM-->>T: Deployment initialized
  end
  T-->>Dev: Report results per parameter
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description only contains the template placeholders and guidance but does not include any actual content in the Description or Test Coverage sections. It fails to explain the issue, the solution, or list relevant tests. As such, it does not satisfy the required template structure or provide the information needed for review. Please fill in the Description section with a concise explanation of the changes and their rationale, and complete the Test Coverage section with the relevant test cases to ensure the PR description is informative and adheres to the repository’s template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The title “[None][chore] AutoDeploy: clean up accuracy test configs” correctly follows the repository’s ticket-and-type convention and concisely describes the primary change of cleaning up AutoDeploy accuracy test configurations. It aligns with the updates to test parameterization and test list entries. It is clear and specific enough for a reviewer to understand the main intent.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bc2d9e and d7eee0c.

📒 Files selected for processing (6)
  • tests/integration/defs/accuracy/test_llm_api_autodeploy.py (1 hunks)
  • tests/integration/test_lists/test-db/l0_b200.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml (0 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_h100.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_dgx_h200.yml (1 hunks)
  • tests/integration/test_lists/test-db/l0_h100.yml (1 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/test-db/l0_dgx_b200.yml
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use only spaces, no tabs; indent with 4 spaces.

Files:

  • tests/integration/defs/accuracy/test_llm_api_autodeploy.py
**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.

Files:

  • tests/integration/defs/accuracy/test_llm_api_autodeploy.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).

Files:

  • tests/integration/defs/accuracy/test_llm_api_autodeploy.py
🧬 Code graph analysis (1)
tests/integration/defs/accuracy/test_llm_api_autodeploy.py (1)
tensorrt_llm/_torch/auto_deploy/models/factory.py (2)
  • model (54-56)
  • tokenizer (59-61)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (5)
tests/integration/defs/accuracy/test_llm_api_autodeploy.py (1)

69-80: LGTM! Parametrization enables multi-scale testing.

The addition of @pytest.mark.parametrize("world_size", [1, 2, 4]) and passing world_size=world_size to AutoDeployLLM is a clean approach to test the AutoDeploy functionality at multiple deployment scales (single-GPU, 2-GPU, and 4-GPU). The changes are minimal, focused, and properly integrated with the test harness.

tests/integration/test_lists/test-db/l0_dgx_h100.yml (1)

43-43: LGTM! Parameterized test variant aligns with hardware.

The update to test_auto_dtype[2] is appropriate for the DGX H100 configuration, which has 2 GPUs available (as specified in the condition ranges). This ensures the test runs with world_size=2, matching the hardware constraints.

tests/integration/test_lists/test-db/l0_b200.yml (1)

76-77: LGTM! Single-GPU variant added for B200.

The addition of test_auto_dtype[1] is appropriate for the B200 configuration, which has 1 GPU available (as specified in the condition ranges). The section header comment improves readability.

tests/integration/test_lists/test-db/l0_h100.yml (1)

116-116: LGTM! Parameterized test variant aligns with hardware.

The update to test_auto_dtype[1] is appropriate for the H100 configuration, which has 1 GPU available (as specified in the condition ranges). This ensures the test runs with world_size=1, matching the hardware constraints.

tests/integration/test_lists/test-db/l0_dgx_h200.yml (1)

122-123: LGTM! 4-GPU variant added for DGX H200.

The addition of test_auto_dtype[4] is appropriate for the DGX H200 configuration, which has 4 GPUs available (as specified in the condition ranges). This ensures the test runs with world_size=4, enabling testing at a larger scale. The section header comment improves organization.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20598 [ run ] triggered by Bot

@lucaslie lucaslie enabled auto-merge (squash) October 3, 2025 18:00
@tensorrt-cicd
Copy link
Collaborator

PR_Github #20598 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15550 completed with status: 'FAILURE'

@lucaslie
Copy link
Member Author

lucaslie commented Oct 3, 2025

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20610 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20610 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15559 completed with status: 'FAILURE'

@lucaslie lucaslie force-pushed the ll/accuracy_test_configs branch from d7eee0c to 3367d66 Compare October 6, 2025 13:43
@lucaslie
Copy link
Member Author

lucaslie commented Oct 6, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20674 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #20674 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15617 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@lucaslie lucaslie merged commit 3492391 into NVIDIA:main Oct 6, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in AutoDeploy Board Oct 6, 2025
@lucaslie lucaslie deleted the ll/accuracy_test_configs branch October 6, 2025 20:59
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 1, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
dominicshanshan pushed a commit to dominicshanshan/TensorRT-LLM that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants