-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[None][feat] Add NCCL device kernels for AR+RMS fusion #7910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nv-lschneider
wants to merge
17
commits into
NVIDIA:main
Choose a base branch
from
nv-lschneider:introducing-nccl-device-ar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,467
−72
Open
Changes from 5 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
56bf9d0
Introducing a new AR strategy that makes use if NCCL symmetric memory…
nv-lschneider 9367328
[https://nvbugs/5351244][fix] CHERRY-PICK test_mpi_session (#7501) (#…
Superjomn 08bf35d
first step new allreduce
nv-lschneider ca6dd60
configurable explore 2d option
nv-lschneider d50cd23
reset files, I don't want to touch
nv-lschneider 51e9ea1
fixing precommit
nv-lschneider 23d0bc8
fix precommit
nv-lschneider fe263e1
printing csv output correctly
nv-lschneider 847b37e
remove auto skip
nv-lschneider 0ae48b5
instrumenting to investigate potential fallbacks
nv-lschneider 64f2c1d
fixes
nv-lschneider ca75549
more instrumenting
nv-lschneider dc090ea
remove old check
nv-lschneider 6b9ec8d
exclude NCCL_DEVICE from stupid checks
nv-lschneider b1ec81e
topology detection skip for stratgies that don't need it
nv-lschneider 260ee61
refactor into function
nv-lschneider 6cc2722
reverting to simpler strategy
nv-lschneider File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| commIter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # | ||
| # SPDX-FileCopyrightText: Copyright (c) 1993-2025 NVIDIA CORPORATION & | ||
| # AFFILIATES. All rights reserved. SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| # use this file except in compliance with the License. You may obtain a copy of | ||
| # the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
| # | ||
|
|
||
| # CMakeLists.txt for nccl_device This directory contains CUDA kernels and host | ||
| # launcher code | ||
|
|
||
| # Enable CUDA | ||
| enable_language(CUDA) | ||
|
|
||
| # Create CUDA library | ||
| add_library(tensorrt_llm_nccl_device config.cu) | ||
|
|
||
| # Set properties for the CUDA library | ||
| set_target_properties( | ||
| tensorrt_llm_nccl_device | ||
| PROPERTIES CUDA_STANDARD 17 CUDA_SEPARABLE_COMPILATION ON | ||
| POSITION_INDEPENDENT_CODE ON) | ||
|
|
||
| # Include directories | ||
| target_include_directories( | ||
| tensorrt_llm_nccl_device PUBLIC ${CMAKE_CURRENT_SOURCE_DIR} | ||
| ${CMAKE_CURRENT_SOURCE_DIR}/../..) | ||
|
|
||
| # Link libraries | ||
| target_link_libraries(tensorrt_llm_nccl_device tensorrt_llm_common) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.