Skip to content

[#6102][fix] support non-system python installation #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 26, 2025
Merged

[#6102][fix] support non-system python installation #7763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
20b3084
[#6102][fix] support non-system python installation
tongyuantongyu Sep 16, 2025
ce86dc5
Merge branch 'main' into ytong/non-system-python-install
tongyuantongyu Sep 18, 2025
e5cfe6b
Merge branch 'main' into ytong/non-system-python-install
tongyuantongyu Sep 19, 2025
01a5e6e
Merge branch 'main' into ytong/non-system-python-install
tongyuantongyu Sep 21, 2025
2f9e143
Merge remote-tracking branch 'refs/remotes/public/main' into ytong/no…
tongyuantongyu Sep 24, 2025
e0a25ef
preload python library for venv
tongyuantongyu Sep 24, 2025
32e8212
update docstring explanation
tongyuantongyu Sep 25, 2025
b7cc271
Merge remote-tracking branch 'public/main' into ytong/non-system-pyth…
tongyuantongyu Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cpp/tensorrt_llm/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,10 @@ if(TARGET ${NIXL_WRAPPER_TARGET})
endif()

if(NOT WIN32)
set_target_properties(${SHARED_TARGET} PROPERTIES BUILD_RPATH "$ORIGIN")
# Load libraries at $PREFIX/lib from
# $PREFIX/lib/python3.12/site-packages/tensorrt_llm/libs
set_target_properties(${SHARED_TARGET}
PROPERTIES BUILD_RPATH "$ORIGIN;$ORIGIN/../../../..")
endif()

if(BUILD_PYT)
Expand Down
16 changes: 9 additions & 7 deletions cpp/tensorrt_llm/nanobind/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@ endif()
target_link_libraries(
${TRTLLM_NB_MODULE}
PUBLIC ${SHARED_TARGET}
${UNDEFINED_FLAG}
${NO_AS_NEEDED_FLAG}
${Python3_LIBRARIES}
${TORCH_LIBRARIES}
torch_python
Expand All @@ -54,10 +52,14 @@ target_compile_definitions(
PYBIND11_DETAILED_ERROR_MESSAGES=1)

if(NOT WIN32)
set_target_properties(
${TRTLLM_NB_MODULE}
PROPERTIES
LINK_FLAGS
"-Wl,-rpath,'$ORIGIN/libs' -Wl,-rpath,'$ORIGIN/../nvidia/nccl/lib' ${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}"
set(TRTLLM_NB_MODULE_RPATH_LIST
"$ORIGIN/libs" # TRTLLM libraries
"$ORIGIN/../../.." # Shared libraries under $PREFIX/lib
"$ORIGIN/../nvidia/nccl/lib" # NCCL libraries
)
set_target_properties(${TRTLLM_NB_MODULE}
PROPERTIES BUILD_RPATH "${TRTLLM_NB_MODULE_RPATH_LIST}")
set_target_properties(
${TRTLLM_NB_MODULE} PROPERTIES LINK_FLAGS
"${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}")
endif()
17 changes: 10 additions & 7 deletions cpp/tensorrt_llm/pybind/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ endif()
target_link_libraries(
${TRTLLM_PYBIND_MODULE}
PUBLIC ${SHARED_TARGET}
${UNDEFINED_FLAG}
${NO_AS_NEEDED_FLAG}
${Python3_LIBRARIES}
${TORCH_LIBRARIES}
torch_python
Expand All @@ -56,10 +54,15 @@ target_compile_definitions(
PYBIND11_DETAILED_ERROR_MESSAGES=1)

if(NOT WIN32)
set_target_properties(
${TRTLLM_PYBIND_MODULE}
PROPERTIES
LINK_FLAGS
"-Wl,-rpath,'$ORIGIN/libs' -Wl,-rpath,'$ORIGIN/../nvidia/nccl/lib' ${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}"
set(TRTLLM_PYBIND_MODULE_RPATH_LIST
"$ORIGIN/libs" # TRTLLM libraries
"$ORIGIN/../../.." # Shared libraries under $PREFIX/lib
"$ORIGIN/../nvidia/nccl/lib" # NCCL libraries
)
set_target_properties(
${TRTLLM_PYBIND_MODULE} PROPERTIES BUILD_RPATH
"${TRTLLM_PYBIND_MODULE_RPATH_LIST}")
set_target_properties(
${TRTLLM_PYBIND_MODULE} PROPERTIES LINK_FLAGS
"${AS_NEEDED_FLAG} ${UNDEFINED_FLAG}")
endif()
29 changes: 29 additions & 0 deletions tensorrt_llm/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,35 @@ def _add_trt_llm_dll_directory():

_add_trt_llm_dll_directory()


def _preload_python_lib():
"""
Preload Python library.

On Linux, the python executable links to libpython statically,
so the dynamic library `libpython3.x.so` is not loaded.
When using virtual environment on top of non-system Python installation,
our libraries installed under `$VENV_PREFIX/lib/python3.x/site-packages/`
have difficulties loading `$PREFIX/lib/libpython3.x.so.1.0` on their own,
since venv does not symlink `libpython3.x.so` into `$VENV_PREFIX/lib/`,
and the relative path from `$VENV_PREFIX` to `$PREFIX` is arbitrary.

We preload the libraries here since the Python executable under `$PREFIX/bin`
can easily find the library.
"""
import platform
on_linux = platform.system() == "Linux"
if on_linux:
import sys
from ctypes import cdll
v_major, v_minor, *_ = sys.version_info
pythonlib = f'libpython{v_major}.{v_minor}.so'
_ = cdll.LoadLibrary(pythonlib + '.1.0')
_ = cdll.LoadLibrary(pythonlib)


_preload_python_lib()

import sys

# Need to import torch before tensorrt_llm library, otherwise some shared binary files
Expand Down