[None][ci] debug thop/parallel tests #7621
Conversation
Signed-off-by: junq <[email protected]>
|
/bot run --stage-list "B200_PCIe-PyTorch-1" |
QiJune
changed the title
📝 WalkthroughWalkthroughEnables detailed logging in Jenkins tests, propagating -s to pytest when DETAILED_LOG is true. Reduces GPU count from 2 to 1 for B200_PCIe-PyTorch-1/2 in Jenkins. Adds -s to integration unittest runner. Removes most PyTorch pre_merge entries from l0_b200.yml. Adds an env print in a FP8 unittest. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (1 passed, 2 warnings)❌ Failed Checks (2 warnings)
✅ Passed Checks (1 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
tests/unittest/_torch/thop/parallel/test_fp8_linear.py (2)
14-16: Prefix the diagnostic with worker id and avoid printing 'None'.This makes logs easier to correlate across -n runs and keeps the value readable when unset.
- print( - f"TORCHINDUCTOR_COMPILE_THREADS is: {os.environ.get('TORCHINDUCTOR_COMPILE_THREADS')}" - ) + worker = os.environ.get("PYTEST_XDIST_WORKER", "gw0") + val = os.environ.get("TORCHINDUCTOR_COMPILE_THREADS", "<unset>") + print(f"[{worker}] TORCHINDUCTOR_COMPILE_THREADS={val}")
1-6: Add SPDX header (consistent with repo style, current year).Tests are Python sources too; mirror the header used elsewhere.
+# SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License.tests/integration/defs/test_unittests.py (1)
126-128: Prefer --capture=tee-sys over -s to stream output and keep JUnit out-err.-s disables capture, which can drop stdout/stderr from the JUnit XML despite setting junit_logging=out-err. tee-sys shows logs live and preserves them in reports.
- command = [ - '-m', 'pytest', ignore_opt, "-s", "-v", "--timeout=2400", + command = [ + '-m', 'pytest', ignore_opt, "--capture=tee-sys", "-v", "--timeout=2400", "--timeout-method=thread" ]
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
jenkins/L0_Test.groovy(1 hunks)tests/integration/defs/test_unittests.py(1 hunks)tests/integration/test_lists/test-db/l0_b200.yml(0 hunks)tests/unittest/_torch/thop/parallel/test_fp8_linear.py(1 hunks)
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/test-db/l0_b200.yml
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/unittest/_torch/thop/parallel/test_fp8_linear.pytests/integration/defs/test_unittests.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/unittest/_torch/thop/parallel/test_fp8_linear.pytests/integration/defs/test_unittests.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/unittest/_torch/thop/parallel/test_fp8_linear.pytests/integration/defs/test_unittests.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
jenkins/L0_Test.groovy (1)
1992-1992: B200 PyTorch split reduction verified – no references to “B200_PCIe-PyTorch-2” remain and both PyTorch blocks in tests/integration/test_lists/test-db/l0_b200.yml (pre_merge and post_merge) will run under split 1.
|
PR_Github #18075 [ run ] triggered by Bot |
|
PR_Github #18075 [ run ] completed with state |
Signed-off-by: junq <[email protected]>
|
/bot run --stage-list "B200_PCIe-PyTorch-1" |
|
PR_Github #18083 [ run ] triggered by Bot |
|
PR_Github #18083 [ run ] completed with state |
Signed-off-by: junq <[email protected]>
|
/bot run --stage-list "B200_PCIe-PyTorch-1" |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/unittest/_torch/thop/parallel/test_fp8_linear.py (1)
1-1: Add required NVIDIA Apache-2.0 header.Per repo guidelines, prepend the SPDX header with the current year.
+ # SPDX-FileCopyrightText: Copyright (c) 2022-2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. + # SPDX-License-Identifier: Apache-2.0
🧹 Nitpick comments (2)
tests/unittest/_torch/thop/parallel/test_fp8_linear.py (1)
14-16: Nit: avoid printing "None"; make message crisp.Provide a default value and a short prefix to aid log grepping.
- print( - f"TORCHINDUCTOR_COMPILE_THREADS is: {os.environ.get('TORCHINDUCTOR_COMPILE_THREADS')}" - ) + val = os.environ.get("TORCHINDUCTOR_COMPILE_THREADS", "<unset>") + print(f"[test_fp8_linear] TORCHINDUCTOR_COMPILE_THREADS={val}")jenkins/L0_Test.groovy (1)
1630-1631: Avoid passing -s twice to pytest.You always add "-s" and add it again when DETAILED_LOG is true. Drop the unconditional one.
def testCmdLine = [ "LLM_ROOT=${llmSrc}", "LLM_BACKEND_ROOT=${llmSrc}/triton_backend", "LLM_MODELS_ROOT=${MODEL_CACHE_DIR}", "MODEL_CACHE_DIR=${MODEL_CACHE_DIR}", extraInternalEnv, "pytest", "-v", - "-s", testFilter[(DETAILED_LOG)] ? "-s" : "", "--timeout-method=thread",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
jenkins/L0_Test.groovy(3 hunks)tests/integration/defs/test_unittests.py(1 hunks)tests/integration/test_lists/test-db/l0_b200.yml(0 hunks)tests/unittest/_torch/thop/parallel/test_fp8_linear.py(1 hunks)
💤 Files with no reviewable changes (1)
- tests/integration/test_lists/test-db/l0_b200.yml
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{h,hpp,hh,hxx,cpp,cxx,cc,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Use only spaces, no tabs; indent with 4 spaces.
Files:
tests/integration/defs/test_unittests.pytests/unittest/_torch/thop/parallel/test_fp8_linear.py
**/*.py
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
**/*.py: Python code must target Python 3.8+.
Indent Python code with 4 spaces; do not use tabs.
Maintain module namespace when importing; prefer 'from package.subpackage import foo' then 'foo.SomeClass()' instead of importing the class directly.
Python filenames should be snake_case (e.g., some_file.py).
Python classes use PascalCase names.
Functions and methods use snake_case names.
Local variables use snake_case; prefix 'k' for variables that start with a number (e.g., k_99th_percentile).
Global variables use upper SNAKE_CASE prefixed with 'G' (e.g., G_MY_GLOBAL).
Constants use upper SNAKE_CASE (e.g., MY_CONSTANT).
Avoid shadowing variables from an outer scope.
Initialize all externally visible members of a class in the constructor.
Prefer docstrings for interfaces that may be used outside a file; comments for in-function or file-local interfaces.
Use Google-style docstrings for classes and functions (Sphinx-parsable).
Document attributes and variables inline so they render under the class/function docstring.
Avoid reflection when a simpler, explicit approach suffices (e.g., avoid dict(**locals()) patterns).
In try/except, catch the most specific exceptions possible.
For duck-typing try/except, keep the try body minimal and use else for the main logic.
Files:
tests/integration/defs/test_unittests.pytests/unittest/_torch/thop/parallel/test_fp8_linear.py
**/*.{cpp,cxx,cc,h,hpp,hh,hxx,cu,cuh,py}
📄 CodeRabbit inference engine (CODING_GUIDELINES.md)
Prepend the NVIDIA Apache-2.0 copyright header with current year to the top of all source files (e.g., .cpp, .h, .cu, .py).
Files:
tests/integration/defs/test_unittests.pytests/unittest/_torch/thop/parallel/test_fp8_linear.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (3)
tests/integration/defs/test_unittests.py (1)
125-128: LGTM: enable stdout capture for unittest run.Adding -s improves debugging; timeout settings preserved.
jenkins/L0_Test.groovy (2)
658-659: Confirm intent: DETAILED_LOG default set to true.This will increase console and artifact sizes for all stages. If this is only for short-term debugging, consider reverting to false post-investigation.
1993-1993: Mapping for B200_PCIe-PyTorch is consistent: no “-2” variant exists and the GPU count is correctly set to 1.
|
PR_Github #18096 [ run ] triggered by Bot |
Signed-off-by: junq <[email protected]>
|
/bot run --stage-list "B200_PCIe-PyTorch-1" |
|
PR_Github #18102 [ run ] triggered by Bot |
|
PR_Github #18096 [ run ] completed with state |
|
PR_Github #18102 [ run ] completed with state |
2 participants
Summary by CodeRabbit
Tests
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.