[https://nvbugs/5351244][fix] test_mpi_session

[Superjomn]

Summary by CodeRabbit

• Tests
  • Re-enabled a previously skipped remote MPI session test.
  • Improved test robustness by resolving paths at runtime and validating script presence.
  • Executions now run with explicit working directory and absolute paths.
  • Added real-time streaming of test output to aid debugging.
  • Tests now fail clearly on non-zero exit codes.
  • Overall increases reliability and visibility of test behavior in CI.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

• PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

• PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

• Test cases are provided for new code paths (see test instructions)

• Any new dependencies have been scanned for license and vulnerabilities

• CODEOWNERS updated if ownership changes

• Documentation updated as needed

• The reviewers assigned automatically/manually are appropriate for the PR.

• Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

[coderabbitai]

📝 Walkthrough

Walkthrough

Test test_remote_mpi_session now resolves the test script path at runtime, invokes it via bash with an absolute path, streams subprocess stdout/stderr concurrently via threads, waits for completion, joins threads, and raises CalledProcessError on non-zero exit. Uses Popen context, passes environment, and sets cwd to the script directory.

Changes

Cohort / File(s)	Summary of changes
MPI session subprocess handling in tests tests/unittest/llmapi/test_mpi_session.py	Removed skip, kept parametrize; compute absolute script path and assert existence; invoke via bash <abs_script> <task_type> with cwd set to script dir; use subprocess.Popen context; concurrently stream stdout/stderr via threads; wait/join threads; raise CalledProcessError on non-zero return code; print final command.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant T as PyTest Test
    participant P as Subprocess (bash script)
    participant O as Stdout Thread
    participant E as Stderr Thread

    T->>T: Resolve absolute script path and cwd
    T->>P: Popen(["bash", script, task_type], env, cwd)
    note right of P: Process starts

    T->>O: Start thread to read stdout
    T->>E: Start thread to read stderr

    par Stream outputs
        O->>T: Forward stdout lines
        E->>T: Forward stderr lines
    end

    T->>P: Wait for process to exit
    P-->>T: Return code

    T->>O: Join
    T->>E: Join

    alt Non-zero return code
        T->>T: Raise CalledProcessError
    else Success
        T->>T: Continue/finish test
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• MartinMarciniszyn
• Tabrizian

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Superjomn]

/bot run

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

tests/unittest/llmapi/test_mpi_session.py (1)

1-7: Add NVIDIA copyright header (2025) per repo guidelines.

Tests are source files too; missing header may fail license checks.

+# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
+
 import os
 import subprocess  # nosec B404
 import sys
 import threading
 from subprocess import PIPE, Popen
 from typing import Literal

🧹 Nitpick comments (2)

tests/unittest/llmapi/test_mpi_session.py (2)

59-59: Docstring punctuation (Ruff D415).

End the first docstring line with a period.

-    """Test RemoteMpiPoolSessionClient and RemoteMpiPoolSessionServer interaction"""
+    """Test RemoteMpiPoolSessionClient and RemoteMpiPoolSessionServer interaction."""

---

60-63: Solid path fix; consider timeout + encoding + reuse cur_dir; skip if script missing.

• Use pytest.skip instead of assert for missing helper script.
• Prefer text=True and explicit UTF-8 encoding over universal_newlines.
• Reuse cur_dir for cwd.
• Add a timeout to avoid CI hangs; kill on timeout.

     cur_dir = os.path.dirname(os.path.abspath(__file__))
     test_file = os.path.join(cur_dir, "_test_remote_mpi_session.sh")
-    assert os.path.exists(test_file), f"Test file {test_file} does not exist"
+    if not os.path.exists(test_file):
+        pytest.skip(f"Test file {test_file} does not exist")
     command = ["bash", test_file, task_type]
     print(' '.join(command))

     with Popen(command,
                env=os.environ,
                stdout=PIPE,
                stderr=PIPE,
                bufsize=1,
                start_new_session=True,
-               universal_newlines=True,
-               cwd=os.path.dirname(os.path.abspath(__file__))) as process:
+               text=True,
+               encoding="utf-8",
+               cwd=cur_dir) as process:
@@
-        return_code = process.wait()
+        try:
+            timeout_sec = int(os.getenv("TLLM_TEST_TIMEOUT_SEC", "300"))
+            return_code = process.wait(timeout=timeout_sec)
+        except subprocess.TimeoutExpired:
+            process.kill()
+            raise

Also applies to: 66-74, 91-99

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9eecdf2 and bef75de.

📒 Files selected for processing (1)

• tests/unittest/llmapi/test_mpi_session.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

**/*

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Filenames compiled into a target must be case-insensitively unique

Files:

• tests/unittest/llmapi/test_mpi_session.py

**/*.{h,hpp,hh,hxx,cc,cpp,cxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Use spaces, not tabs; indent 4 spaces

Files:

• tests/unittest/llmapi/test_mpi_session.py

**/*.py

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

**/*.py: Code must target Python 3.8+
Indent with 4 spaces; do not use tabs (Python)
Maintain module namespace on import: prefer from package.subpackage import foo; use foo.Symbol()
Python filenames use snake_case
Python class names use PascalCase
Python functions and methods use snake_case
Python local variables use snake_case; if starting with a number concept, prefix with k (e.g., k_99th_percentile)
Python global variables use G_ prefix with UPPER_SNAKE_CASE
Python constants use UPPER_SNAKE_CASE
Avoid shadowing variables from outer scopes
Initialize all externally visible class members in init
For public interfaces, prefer docstrings over comments; comments should be for in-function or file-local interfaces
Use Google-style docstrings for classes and functions (Sphinx-parsable)
Document attributes and variables inline with docstrings immediately after assignment
Avoid reflection when a non-reflective approach suffices
Limit except clauses to specific exceptions where possible
When using try/except for duck-typing, keep try body minimal and move logic to else

Files:

• tests/unittest/llmapi/test_mpi_session.py

**/*.{cpp,cc,cxx,h,hpp,hh,hxx,cu,cuh,py}

📄 CodeRabbit inference engine (CODING_GUIDELINES.md)

Prepend NVIDIA copyright header (current year) to all source files

Files:

• tests/unittest/llmapi/test_mpi_session.py

🪛 Ruff (0.12.2)

tests/unittest/llmapi/test_mpi_session.py

62-62: First line should end with a period, question mark, or exclamation point

Add closing punctuation

(D415)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Pre-commit Check

[tensorrt-cicd]

PR_Github #17512 [ run ] triggered by Bot

[tensorrt-cicd]

PR_Github #17512 [ run ] completed with state SUCCESS
/LLM/release-1.0/L0_MergeRequest_PR pipeline #346 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.