[None][debug]Update for debugging node 081 #7153
Conversation
Signed-off-by: qqiao <[email protected]>
📝 WalkthroughWalkthroughUpdates Jenkins test scheduling and matrix for specific GPU types, tightening host selection and removing a taints check. Reworks RTX Pro 6000 post-merge test entries to focus on 8-GPU runs. Aligns the integration test DB for RTX Pro 6000 to require exactly 8 GPUs. Changes
Sequence Diagram(s)sequenceDiagram
participant Jenkins
participant K8sScheduler as K8s Scheduler
participant Node as Host(sm c521ge-0081...)
participant TestDB as Test DB (l0_rtx_pro_6000)
Jenkins->>K8sScheduler: Schedule RTX Pro 6000 post-merge job (8-GPU)
K8sScheduler->>K8sScheduler: Apply nodeSelector hostname filter
K8sScheduler->>Node: Place pod on specified host
Jenkins->>TestDB: Query test list (requires 8 GPUs)
TestDB-->>Jenkins: Return matching tests
Jenkins->>Node: Execute tests with 8 GPUs
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
jenkins/L0_Test.groovy (1)
662-669: Hard pinning many GPU types to a single host will break schedulingAdding kubernetes.io/hostname: smc521ge-0081.ipp2a2.colossus under a broad condition affects dgx-h100, dgx-h200, rtx-pro-6000, b100-ts2, gh200, rtx-5080, rtx-5090. This effectively forces all those jobs onto a single node, reducing capacity and likely causing unschedulable pods for non-RTXPro6000 flows.
Scope the pin to RTXPro6000 only and guard it behind an explicit opt‑in env flag, so default behavior remains unchanged for other platforms.
Apply this minimal diff to localize the host pin:
- // The following GPU types doesn't support dynamic driver flashing. - if (type.contains("dgx-h100") || type.contains("dgx-h200") || type.contains("rtx-pro-6000") || type in ["b100-ts2", "gh200", "rtx-5080", "rtx-5090"]) { + // Optional: pin RTX Pro 6000 jobs to node 081 for debugging only when explicitly requested. + if (type.contains("rtx-pro-6000") && (env.PIN_TO_NODE_081 == "true")) { selectors = """ kubernetes.io/arch: ${arch} kubernetes.io/os: linux kubernetes.io/hostname: smc521ge-0081.ipp2a2.colossus nvidia.com/gpu_type: ${gpuType}"""Follow-up:
- Set PIN_TO_NODE_081=true only for the temporary debug pipeline.
- If you truly need to pin other GPU families, add dedicated, opt‑in flags for each instead of a broad match.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
jenkins/L0_Test.groovy(2 hunks)tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Pre-commit Check
🔇 Additional comments (1)
tests/integration/test_lists/test-db/l0_rtx_pro_6000.yml (1)
37-38: 8‑GPU gating: confirm intent and downstream readinessYou tightened the condition to require exactly 8 GPUs. Given that the selected tests are parameterized as “..._4gpus”, please confirm:
- These tests are expected to run on an 8‑GPU pod (using only 4 visible/allocated devices internally), and
- Dropping the previous single‑GPU RTX Pro 6000 post‑merge stage is intentional.
If both are expected, no code change needed; otherwise consider splitting an 8‑GPU block for true 8‑GPU cases and retaining a 1‑GPU/4‑GPU block as needed.
|
PR_Github #16157 [ run ] triggered by Bot |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16163 [ run ] triggered by Bot |
|
PR_Github #16157 [ run ] completed with state |
|
PR_Github #16163 [ run ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16382 [ run ] triggered by Bot |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16402 [ run ] triggered by Bot |
|
PR_Github #16382 [ run ] completed with state |
|
PR_Github #16402 [ run ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16494 [ run ] triggered by Bot |
|
PR_Github #16494 [ run ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16537 [ run ] triggered by Bot |
|
PR_Github #16537 [ run ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16548 [ run ] triggered by Bot |
|
PR_Github #16548 [ run ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16612 [ run ] triggered by Bot |
|
/bot kill |
|
PR_Github #16650 [ kill ] triggered by Bot |
|
PR_Github #16612 [ run ] completed with state |
|
PR_Github #16650 [ kill ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16656 [ run ] triggered by Bot |
|
/bot kill |
|
PR_Github #16687 [ kill ] triggered by Bot |
|
PR_Github #16656 [ run ] completed with state |
|
PR_Github #16687 [ kill ] completed with state |
|
/bot run --debug --stage-list "RTXPro6000-8_GPUs-Pytorch-Post-Merge-1" |
|
PR_Github #16764 [ run ] triggered by Bot |
|
/bot kill |
|
PR_Github #16832 [ kill ] triggered by Bot |
|
PR_Github #16764 [ run ] completed with state |
|
PR_Github #16832 [ kill ] completed with state |
4 participants
Summary by CodeRabbit
Tests
Chores
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.