[TRTLLM-6637][feat] Resolve KV cache divergence issue #6628
Conversation
📝 WalkthroughWalkthroughThis change introduces separate tracking of context position and prepopulated prompt length for draft and target modes in Changes
Sequence Diagram(s)sequenceDiagram
participant Executor
participant ResourceManager
participant KVCacheManager
participant LlmRequest
Executor->>ResourceManager: prepare_resources(scheduled_batch)
ResourceManager->>KVCacheManager: prepare_resources(scheduled_batch)
KVCacheManager->>ResourceManager: request_context(is_draft, scheduled_batch)
loop For each request in scheduled_batch
ResourceManager->>LlmRequest: set use_draft_model = is_draft
end
KVCacheManager->>KVCacheManager: (resource preparation logic)
loop For each request in scheduled_batch
ResourceManager->>LlmRequest: set use_draft_model = False
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (8)
🚧 Files skipped from review as they are similar to previous changes (8)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run |
|
PR_Github #14133 [ run ] triggered by Bot |
|
PR_Github #14133 [ run ] completed with state |
|
/bot run |
|
PR_Github #14194 [ run ] triggered by Bot |
|
PR_Github #14194 [ run ] completed with state |
ziyixiong-nv
force-pushed
the
dev-fxiong-kv-cache-divergence-fix
branch
from
8e3aaa4 to
cfd85cb
Compare
|
/bot run |
|
PR_Github #14215 [ run ] triggered by Bot |
|
PR_Github #14215 [ run ] completed with state |
|
/bot run |
|
PR_Github #14251 [ run ] triggered by Bot |
|
PR_Github #14251 [ run ] completed with state |
ziyixiong-nv
force-pushed
the
dev-fxiong-kv-cache-divergence-fix
branch
2 times, most recently
from
f93cb9d to
54418a2
Compare
|
/bot run |
|
PR_Github #14381 [ run ] triggered by Bot |
|
PR_Github #14381 [ run ] completed with state |
|
/bot run |
|
PR_Github #14406 [ run ] triggered by Bot |
|
PR_Github #14406 [ run ] completed with state |
ziyixiong-nv
force-pushed
the
dev-fxiong-kv-cache-divergence-fix
branch
from
2667b84 to
24cea1d
Compare
|
/bot run |
|
PR_Github #14537 [ run ] triggered by Bot |
|
PR_Github #14537 [ run ] completed with state |
ziyixiong-nv
force-pushed
the
dev-fxiong-kv-cache-divergence-fix
branch
from
24cea1d to
07886bc
Compare
|
/bot run |
|
PR_Github #14569 [ run ] triggered by Bot |
|
PR_Github #14569 [ run ] completed with state |
ziyixiong-nv
force-pushed
the
dev-fxiong-kv-cache-divergence-fix
branch
from
07886bc to
6de50c2
Compare
|
/bot run |
|
PR_Github #14613 [ run ] triggered by Bot |
|
PR_Github #14613 [ run ] completed with state |
Signed-off-by: ziyixiong-nv <[email protected]>
Signed-off-by: ziyixiong-nv <[email protected]>
ziyixiong-nv
force-pushed
the
dev-fxiong-kv-cache-divergence-fix
branch
from
6de50c2 to
f7b6973
Compare
|
/bot run |
|
PR_Github #14658 [ run ] triggered by Bot |
|
PR_Github #14658 [ run ] completed with state |
4 participants
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Description
There could be KV cache divergence issue caused by the mutation of
context_current_position.The PR is resolving this issue by separating the
context_current_positionandprepopulated_prompt_lenfor target and draft model.Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.