Skip to content

[None][fix] Serialize the window_size in the kv event #6526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2025
Merged

[None][fix] Serialize the window_size in the kv event #6526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71b036c
add the window_size to the KvCacheEvent
richardhuo-nv Jul 31, 2025
2908cf0
fix test
richardhuo-nv Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tensorrt_llm/_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,7 @@ def to_json_str(cls, event):
return {
"event_id": event.event_id,
"data": event_serialize_func(event.data),
"window_size": event.window_size
}

@staticmethod
Expand Down
3 changes: 2 additions & 1 deletion tests/unittest/llmapi/test_llm_kv_cache_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ def test_kv_cache_event_data_serialization():
flush_events(kv_cache_manager)
events = kv_cache_manager.get_latest_events(10)
serialized_event = KVCacheEventSerializer.serialize(events)
assert len(serialized_event) == 1 and serialized_event[0]["event_id"] == 0
assert len(serialized_event) == 1 and serialized_event[0][
"event_id"] == 0 and serialized_event[0]["window_size"] == 256
assert serialized_event[0]["data"]["type"] == "created"
assert len(serialized_event[0]["data"]["num_blocks_per_cache_level"]) == 2

Expand Down