Skip to content

Conversation

@xinhe-nv
Copy link
Collaborator

@xinhe-nv xinhe-nv commented Jul 27, 2025

Remove closed bugs from waives.txt

Summary by CodeRabbit

  • Chores
    • Re-enabled multiple integration tests, including multimodal and LLM API tests, allowing them to run as part of the regular test suite.
    • Added a waiver entry to temporarily skip a specific benchmark test with a new backend configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 27, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

"""

Walkthrough

Multiple test skip entries have been removed from the waiver list file tests/integration/test_lists/waives.txt for multimodal, LLM API PyTorch, and end-to-end tests. One new skip entry was added for a TRT backend benchmark test. No other modifications were made.

Changes

File(s) Change Summary
Test waiver list
- tests/integration/test_lists/waives.txt
Removed multiple skip entries for multimodal, LLM API PyTorch, and end-to-end tests; added one new skip entry for test_trtllm_bench_llmapi_launch with trt_backend-llama-v3-llama3-8b.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

Possibly related PRs

Suggested reviewers

  • syuoni
  • venkywonka
  • crazydemo
    """

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b44cac and 7089f1f.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@xinhe-nv xinhe-nv requested review from LarryXFly and crazydemo July 27, 2025 12:15
@xinhe-nv xinhe-nv marked this pull request as ready for review July 28, 2025 00:43
@xinhe-nv
Copy link
Collaborator Author

/bot run

@xinhe-nv xinhe-nv changed the title Draft: test: [CI] remove closed bugs test: [CI] remove closed bugs Jul 28, 2025
@xinhe-nv xinhe-nv enabled auto-merge (squash) July 28, 2025 00:44
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13117 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13117 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9814 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250727 branch from 5d3ed60 to a16e1e7 Compare July 28, 2025 02:56
@xinhe-nv
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13138 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #13138 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9837 completed with status: 'FAILURE'

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250727 branch from a16e1e7 to 2216f78 Compare July 29, 2025 06:38
@xinhe-nv
Copy link
Collaborator Author

/bot run

@coderabbitai coderabbitai bot requested review from syuoni and yiqingy0 July 29, 2025 06:38
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13317 [ run ] triggered by Bot

@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250727 branch from 2216f78 to bcebfcd Compare July 29, 2025 08:31
@coderabbitai coderabbitai bot requested a review from venkywonka July 29, 2025 08:31
@tensorrt-cicd
Copy link
Collaborator

PR_Github #13317 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #9951 completed with status: 'FAILURE'

Signed-off-by: xinhe-nv <[email protected]>
@xinhe-nv xinhe-nv force-pushed the user/qa/unwaive_20250727 branch from bcebfcd to 6b44cac Compare July 29, 2025 08:45
@LarryXFly LarryXFly disabled auto-merge July 29, 2025 09:01
@LarryXFly LarryXFly merged commit f1086e7 into NVIDIA:main Jul 29, 2025
2 checks passed
@xinhe-nv xinhe-nv deleted the user/qa/unwaive_20250727 branch July 29, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants