Skip to content

Qwen3: Fix eagle hidden states #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

Qwen3: Fix eagle hidden states #6199

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60483cb
Qwen3: Fix eagle hidden states
IzzyPutterman Jul 20, 2025
8515466
switch to different method
IzzyPutterman Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions tensorrt_llm/_torch/models/modeling_qwen3_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ def forward(
if residual is None:
residual = hidden_states
hidden_states = self.input_layernorm(hidden_states)

if spec_metadata is not None and spec_metadata.is_layer_capture(
self.layer_idx):
self.fusion_config.POST_MOE_FUSION = False
# Self Attention
hidden_states = self.self_attn(
position_ids=position_ids,
Expand Down Expand Up @@ -257,9 +259,6 @@ def forward(

if self.fusion_config.POST_MOE_FUSION:
if do_finalize:
if spec_metadata:
spec_metadata.maybe_capture_hidden_states(
self.layer_idx, hidden_states, residual)
hidden_states, residual = self.allreduce(
hidden_states,
all_reduce_params=AllReduceParams(
Expand Down Expand Up @@ -289,12 +288,8 @@ def forward(
hidden_states, residual = self.moe_allreduce(
fc2_output, all_reduce_params=moe_all_reduce_params)

if spec_metadata:
spec_metadata.maybe_capture_hidden_states(
self.layer_idx, hidden_states, residual)

else:
if spec_metadata:
if spec_metadata and spec_metadata.is_layer_capture(self.layer_idx):
spec_metadata.maybe_capture_hidden_states(
self.layer_idx, hidden_states, residual)
if self.next_layer_layernorm is not None:
Expand Down