fix: NVBug 5385576 py_batch_idx issue #6153
Conversation
|
""" WalkthroughThe changes update the indexing logic used for logits tensor manipulation in the Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
/bot run |
|
PR_Github #12228 [ run ] triggered by Bot |
|
PR_Github #12228 [ run ] completed with state |
|
/bot run |
|
PR_Github #12229 [ run ] triggered by Bot |
|
PR_Github #12229 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #12233 [ run ] triggered by Bot |
|
PR_Github #12233 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
/bot kill |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug related to incorrect batch indexing in logits post-processing (NVBug 5385576) and re-enables a previously skipped test that was disabled due to this issue.
- Corrects indexing logic in logits post-processing to use loop iterator instead of
py_batch_idx - Re-enables the logits processor test that was previously skipped due to the bug
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tensorrt_llm/_torch/pyexecutor/model_engine.py |
Fixed batch indexing in _execute_logit_post_processors method by replacing request.py_batch_idx with loop iterator idx |
tests/integration/defs/llmapi/test_llm_examples.py |
Removed pytest skip decorator from logits processor test, re-enabling it in the test suite |
|
PR_Github #12236 [ kill ] triggered by Bot |
|
PR_Github #12236 [ kill ] completed with state |
|
/bot run |
|
/bot kill |
|
/bot run |
|
PR_Github #12237 [ run ] triggered by Bot |
|
PR_Github #12238 [ kill ] triggered by Bot |
|
PR_Github #12237 [ run ] completed with state |
|
PR_Github #12238 [ kill ] completed with state |
|
PR_Github #12239 [ run ] triggered by Bot |
|
PR_Github #12239 [ run ] completed with state |
Signed-off-by: Erin Ho <[email protected]>
venkywonka
force-pushed
the
nvbug_5385576
branch
from
cbe3453 to
2b4da3d
Compare
|
/bot run |
|
PR_Github #12246 [ run ] triggered by Bot |
|
PR_Github #12246 [ run ] completed with state |
|
/bot run |
|
PR_Github #12287 [ run ] triggered by Bot |
|
PR_Github #12287 [ run ] completed with state |
Signed-off-by: Erin Ho <[email protected]>
Signed-off-by: Erin Ho <[email protected]>
Signed-off-by: Erin Ho <[email protected]> Signed-off-by: Shreyas Misra <[email protected]>
fix: NVBug 5385576 py_batch_idx issue (NVIDIA#6153) Signed-off-by: Erin Ho <[email protected]>
5 participants
Summary by CodeRabbit
Description
Test Coverage
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.md.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.