Perceived - #58
Closed
RichardScottOZ wants to merge 1 commit into
Closed
Conversation
nv-guomingz
added
the
Doc
Collaborator
|
@RichardScottOZ Thanks for your contribution to TRT-LLM. |
longcheng-nv
added a commit
to longcheng-nv/TensorRT-LLM
that referenced
this pull request
Sep 3, 2026
An in-window +inf drives the register-family hint-free bracket max to +inf, so the bracket width GMAX-Tv is +inf and SC=rcp(+inf)=0 folds every value into bin 0. The whole-bin emit then ranks by position and drops the +inf from the top-k (DKG issue NVIDIA#58; oracle and degenerate hints fail identically, so this is in the selection, not the hint). The sentinel fallback did not help because its own width (SENT_HI-SENT_LO) also overflows to +inf. The collapse guard now rejects an infinite bracket width, and the register kernel forces the count-crossing escape whenever the bracket is degenerate (okc=0). The escape ranks the full row in key space independent of the bracket, where fkey(+inf) is the maximum key, so +inf is selected. The finite +/-3e38 and -inf paths are unchanged; NaN ordering stays implementation-specific per the documented limitation. Verified on B200 sm100: the issue repro (in-/out-of-window +inf across N in {4K,16K,64K}, cr in {1,4}) passes, the -inf duplicate-index sweep (3 seed-dependent configs) stays fixed, and the full test_gvr_selfsampling_topk suite is 82 passed. Signed-off-by: longcheng-nv <243710427+longcheng-nv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.