Draft: feat: Optimize CreateNewDecoderRequest #5271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Campora <[email protected]>
|
/bot run |
|
@Funatiq this is still in a rough draft state. I'd like to see how far is it from running. |
|
PR_Github #9162 [ run ] triggered by Bot |
Signed-off-by: Daniel Campora <[email protected]>
|
PR_Github #9162 [ run ] completed with state |
Funatiq
reviewed
Jun 24, 2025
| auto const numDecodingEngineTokens = request.generatedTokensPerEngineStep; | ||
| auto const& requestIds = inputIds; | ||
| auto const inputLength = llmReq.getPromptLen(); | ||
| auto const numDecodingEngineTokens = modelConfig.getMaxDecodingTokens(); |
There was a problem hiding this comment.
I think we need the previous logic here to set the correct value.
|
Fixed in #6559 and follow ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.