Skip to content

Conversation

@nv-guomingz
Copy link
Collaborator

@nv-guomingz nv-guomingz commented Jun 6, 2025

main branch has ut regression with this cmd

pytest tests/unittest/_torch/test_pytorch_model_engine.py::PyTorchModelEngineTestCase

this pr fixed cases

FAILED tests/unittest/_torch/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_layerwise_nvtx_marker - TypeError: argument of type 'NoneType' is not iterable
FAILED tests/unittest/_torch/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_pad_generation_requests - TypeError: argument of type 'NoneType' is not iterable
FAILED tests/unittest/_torch/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_position_id_preparation - TypeError: argument of type 'NoneType' is not iterable
FAILED tests/unittest/_torch/test_pytorch_model_engine.py::PyTorchModelEngineTestCase::test_warmup - TypeError: argument of type 'NoneType' is not iterable

@nv-guomingz nv-guomingz requested a review from a team as a code owner June 6, 2025 02:22
@nv-guomingz nv-guomingz requested review from Superjomn, schetlur-nv and syuoni and removed request for schetlur-nv June 6, 2025 02:22
@nv-guomingz nv-guomingz force-pushed the user/guomingz/fix_nvbug_5324248 branch from 78d2c64 to a57a6d9 Compare June 6, 2025 02:26
@nv-guomingz nv-guomingz requested a review from QiJune June 6, 2025 02:27
@nv-guomingz nv-guomingz force-pushed the user/guomingz/fix_nvbug_5324248 branch from a57a6d9 to a7253cc Compare June 6, 2025 07:04
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7866 [ run ] triggered by Bot

@nv-guomingz nv-guomingz force-pushed the user/guomingz/fix_nvbug_5324248 branch from a7253cc to 24f68c5 Compare June 6, 2025 08:03
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7882 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7866 [ run ] completed with state ABORTED

Copy link
Collaborator

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7882 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5695 completed with status: 'SUCCESS'

Signed-off-by: nv-guomingz <[email protected]>
@nv-guomingz nv-guomingz force-pushed the user/guomingz/fix_nvbug_5324248 branch from 24f68c5 to aec7d87 Compare June 6, 2025 17:17
@nv-guomingz
Copy link
Collaborator Author

/bot reuse-pipeline

@nv-guomingz nv-guomingz enabled auto-merge (squash) June 6, 2025 17:18
@tensorrt-cicd
Copy link
Collaborator

PR_Github #7933 [ reuse-pipeline ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7933 [ reuse-pipeline ] completed with state SUCCESS
Reusing PR_Github #7882 for commit aec7d87

@nv-guomingz nv-guomingz merged commit 0c7dd66 into NVIDIA:main Jun 6, 2025
3 checks passed
@nv-guomingz nv-guomingz deleted the user/guomingz/fix_nvbug_5324248 branch September 30, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants