Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing gpt_variant to model conversion #2352

Closed
wants to merge 2 commits into from
Closed

Passing gpt_variant to model conversion #2352

wants to merge 2 commits into from

Conversation

tonylek
Copy link
Contributor

@tonylek tonylek commented Oct 18, 2024

When I'm passing gpt_variant nothing happens with this, which causes an error with my model since its gpt_variant is not one of the default ones.

@Superjomn Superjomn requested a review from syuoni October 21, 2024 10:16
@Superjomn Superjomn added triaged Issue has been triaged by maintainers build labels Oct 21, 2024
@syuoni
Copy link
Collaborator

syuoni commented Oct 21, 2024

We will integrate this change to our internal repo first. Thanks for the contribution!

@kaiyux kaiyux mentioned this pull request Oct 22, 2024
Merged
@kaiyux
Copy link
Member

kaiyux commented Oct 22, 2024

Hi @tonylek , thanks a lot for your contribution, the changes have been included in #2363, and we've marked you as the co-author.

I'm going to close this PR as the changes are integrated, please let me know for any questions. Thanks for your support!

@kaiyux kaiyux closed this Oct 22, 2024
@Shixiaowei02 Shixiaowei02 mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syuoni syuoni Awaiting requested review from syuoni

Assignees
No one assigned
Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tonylek @syuoni @kaiyux @Superjomn