Repository navigation
[None][fix] Chat Completions: accept the OpenAI store field #20864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JunyiXu-nv
merged 6 commits into
NVIDIA:main
from
JunyiXu-nv:dev-junyix-fix-chat-accept-store
Oct 26, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8f26eba
[None][fix] Chat Completions: accept the OpenAI store field
JunyiXu-nv b7969fe
[None][chore] Merge main (9619d5b2ee) into dev-junyix-fix-chat-accept…
JunyiXu-nv fd33783
[None][test] Chat Completions store: name what the schema accepts and…
JunyiXu-nv 611ee1b
[None][chore] Merge main (ecae3c97e2) into dev-junyix-fix-chat-accept…
JunyiXu-nv 9ee328b
[None][chore] Merge main (a8094061ae) into dev-junyix-fix-chat-accept…
JunyiXu-nv bd133a4
[None][chore] Merge main (b7d6e624d1) into dev-junyix-fix-chat-accept…
JunyiXu-nv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
tests/unittest/llmapi/apps/test_openai_protocol_chat_store.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """ChatCompletionRequest must accept the standard OpenAI `store` field. | ||
|
|
||
| The request schema is extra="forbid", so a request from an OpenAI client that | ||
| sets `store` (the pi coding agent sends `store: false` on every Chat | ||
| Completions request by default) failed validation with HTTP 400. The field is | ||
| accepted and not used: the server keeps no copy of a chat completion. | ||
| """ | ||
|
|
||
| import pytest | ||
| from pydantic import ValidationError | ||
|
|
||
| from tensorrt_llm.serve.openai_protocol import ChatCompletionRequest | ||
|
|
||
| pytestmark = pytest.mark.cpu_only | ||
|
|
||
|
|
||
| def _request(**extra) -> ChatCompletionRequest: | ||
| return ChatCompletionRequest( | ||
| model="test-model", | ||
| messages=[{"role": "user", "content": "hi"}], | ||
| **extra, | ||
| ) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("value", [False, True, None]) | ||
| def test_store_accepted(value): | ||
| assert _request(store=value).store is value | ||
|
|
||
|
|
||
| def test_store_defaults_to_none(): | ||
| assert _request().store is None | ||
|
|
||
|
|
||
| def test_store_accepted_from_json(): | ||
| req = ChatCompletionRequest.model_validate_json( | ||
| '{"model": "test-model", "messages": [{"role": "user", "content": "hi"}],' | ||
| ' "store": false, "stream": true}' | ||
| ) | ||
| assert req.store is False | ||
| assert req.stream is True | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "value, expected", [("false", False), ("true", True), (0, False), (1, True)] | ||
| ) | ||
| def test_store_coerces_boolean_like_values(value, expected): | ||
| # The request schema is not strict, so a boolean-like string or integer is | ||
| # coerced, as for every other boolean field of the request. | ||
| assert _request(store=value).store is expected | ||
|
|
||
|
|
||
| def test_store_rejects_a_value_that_is_not_boolean_like(): | ||
| with pytest.raises(ValidationError): | ||
| _request(store={"keep": True}) | ||
|
|
||
|
|
||
| def test_store_leaves_other_fields_unchanged(): | ||
| plain = _request(temperature=0.5) | ||
| stored = _request(temperature=0.5, store=False) | ||
| assert stored.model_dump(exclude={"store"}) == plain.model_dump(exclude={"store"}) | ||
|
|
||
|
|
||
| def test_unknown_fields_remain_rejected(): | ||
| with pytest.raises(ValidationError): | ||
| _request(stores=False) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.