[None][fix] Validate telemetry deployment IDs as UUIDs by Mgluhovskoi · Pull Request #20777 · NVIDIA/TensorRT-LLM

Mgluhovskoi · 2026-10-21T22:43:22Z

Description

Validate TRTLLM_DISAGG_DEPLOYMENT_ID as a UUID before including it in telemetry. Valid values are normalized to 32 lowercase hexadecimal characters; missing or invalid values produce an empty deploymentId.

Preserves the existing environment-variable propagation and launcher-generated IDs, including shared UUIDs supplied by custom launchers. UUID validation checks format, not provenance or whether a UUID encodes identifying data.

Targets release/1.3. No launcher, schema version, event field, or cache-format changes. Existing historical records are unchanged; future non-UUID IDs are omitted and UUID formatting is normalized.

Test Coverage

Reporter, schema, transport, collectors, and opt-out suites: 238 passed, 6 optional tests skipped.
Covers missing/malformed IDs, paths, emails, valid UUIDs and normalization across initial, heartbeat, and exit payloads, including terminal-only failures.
Updated tests are already included through unittest/usage in CPU CI.
Pre-commit checks passed.

Dev Engineer Review

usage_lib.py validates TRTLLM_DISAGG_DEPLOYMENT_ID as a UUID.
Valid IDs are normalized to 32 lowercase hexadecimal characters.
Missing or invalid IDs produce an empty deploymentId.
Initial, heartbeat, and terminal telemetry use the normalized value.
No launcher, schema version, event field, or cache-format changes are indicated.
Review finding counts are unavailable from the supplied evidence.

QA Engineer Review

tests/unittest/usage/test_reporter.py was modified.
Tests cover missing, malformed, identifying, incorrectly sized, valid, and non-canonical IDs.
Tests cover initial, heartbeat, exit, and terminal-event payloads.
Tests verify that rejected IDs are absent from serialized telemetry.
unittest/usage is listed in tests/integration/test_lists/test-db/l0_cpu.yml.
Reported results include 238 tests passed and 6 optional tests skipped.
Coverage verdict: sufficient.

Per-File QA Perspective

tensorrt_llm/usage/schemas/README.md: Documents UUID validation, lowercase hexadecimal normalization, and empty output for missing or invalid IDs.
tensorrt_llm/usage/usage_lib.py: Verify normalized IDs and empty output across session metadata and telemetry event types. Verify existing environment propagation and snapshot length clamping.
tests/unittest/usage/test_reporter.py: Covers validation, normalization, privacy behavior, and terminal-event correlation. The suite is listed in the CPU CI test list.

Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>

… propagation Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>

Mgluhovskoi · 2026-10-21T23:12:36Z

/bot run

Mgluhovskoi · 2026-10-21T23:12:42Z

/bot run

coderabbitai · 2026-10-21T23:17:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: cc1d7b84-4b96-4614-a288-452d51e9e327

📥 Commits

Reviewing files that changed from the base of the PR and between 135d95a and 276ed1e.

📒 Files selected for processing: 3

tensorrt_llm/usage/schemas/README.md
tensorrt_llm/usage/usage_lib.py
tests/unittest/usage/test_reporter.py

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

Walkthrough

Disaggregated telemetry now parses deployment IDs as UUIDs and emits valid values as lowercase hexadecimal without hyphens. Missing or invalid values produce an empty string. Documentation and tests cover the updated behavior.

Changes

Deployment ID normalization

Layer / File(s)	Summary
UUID validation and normalization `tensorrt_llm/usage/usage_lib.py`, `tensorrt_llm/usage/schemas/README.md`, `tests/unittest/usage/test_reporter.py`	The telemetry helper parses deployment IDs as UUIDs and returns lowercase hexadecimal. Documentation and tests specify and verify this format, including empty output for invalid or unset values.
Telemetry report integration `tensorrt_llm/usage/usage_lib.py`, `tests/unittest/usage/test_reporter.py`	Session metadata and empty event snapshots use normalized deployment IDs. Payload tests check valid and rejected IDs across report events, including terminal-event correlation.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: venkywonka

Merge Risk: ⚪ Minimal · up to 276ed

No actionable issue is established; the change appears mergeable after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title follows the required [None][fix] format and clearly states that telemetry deployment IDs are validated as UUIDs.
Description check		The description explains the problem, solution, scope, compatibility impact, and test coverage. It omits the PR Checklist section, but the core required information is complete.
Docstring Coverage		Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (1 skipped: 1 u…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 85.71% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

tensorrt-cicd · 2026-10-21T23:20:33Z

PR_Github #79704 [ run ] triggered by Bot. Commit: 276ed1e Link to invocation

tensorrt-cicd · 2026-10-21T23:21:02Z

PR_Github #79705 [ run ] triggered by Bot. Commit: 276ed1e Link to invocation

tensorrt-cicd · 2026-10-21T23:21:07Z

PR_Github #79704 [ run ] completed with state ABORTED. Commit: 276ed1e

Link to invocation

github-actions · 2026-10-21T23:31:12Z

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

tensorrt-cicd · 2026-10-22T05:40:06Z

PR_Github #79705 [ run ] completed with state FAILURE. Commit: 276ed1e
/LLM/release-1.3/L0_MergeRequest_PR pipeline #478 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Mgluhovskoi · 2026-10-22T05:49:27Z

/bot run

tensorrt-cicd · 2026-10-22T05:55:52Z

PR_Github #79813 [ run ] triggered by Bot. Commit: 276ed1e Link to invocation

tensorrt-cicd · 2026-10-22T14:14:03Z

PR_Github #79813 [ run ] completed with state FAILURE. Commit: 276ed1e
/LLM/release-1.3/L0_MergeRequest_PR pipeline #498 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

Please check the failed tests and fix your PR
If you cannot view the failures, ask the CI triggerer to share details
Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Mgluhovskoi · 2026-10-22T14:19:13Z

/bot run

tensorrt-cicd · 2026-10-22T14:26:20Z

PR_Github #79903 [ run ] triggered by Bot. Commit: 276ed1e Link to invocation

tensorrt-cicd · 2026-10-22T15:44:27Z

PR_Github #79903 [ run ] completed with state SUCCESS. Commit: 276ed1e
/LLM/release-1.3/L0_MergeRequest_PR pipeline #503 completed with status: 'SUCCESS'

CI Report

Link to invocation

…etry deployment IDs as UUIDs Forward-port of release/1.3 PR NVIDIA#20777 (release/1.3 commit 6c172f3) to main. Adapted to main: the new payload test patches _HEARTBEAT_STOP, which main renamed from _REPORTER_STOP. Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com> Signed-off-by: Simeng Liu <simengl@nvidia.com>

github-actions Bot assigned Mgluhovskoi Oct 21, 2026

[None][fix] Remove user-provided telemetry deployment IDs

5ed325b

Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>

Mgluhovskoi force-pushed the fix/telemetry-generated-deployment-id branch from e4a9254 to 5ed325b Compare October 21, 2026 22:47

Mgluhovskoi changed the base branch from main to release/1.3 October 21, 2026 22:47

[None][fix] Validate deployment UUIDs instead of removing environment…

276ed1e

… propagation Signed-off-by: Maxim Gluhovskoi <mgluhovskoi@nvidia.com>

Mgluhovskoi changed the title ~~[None][fix] Remove user-provided telemetry deployment IDs~~ [None][fix] Validate telemetry deployment IDs as UUIDs Oct 21, 2026

Mgluhovskoi marked this pull request as ready for review October 21, 2026 23:12

Mgluhovskoi requested a review from a team as a code owner October 21, 2026 23:12

Mgluhovskoi requested a review from arysef October 21, 2026 23:12

arysef approved these changes Oct 21, 2026

View reviewed changes

trtllm-agent added the ci: full pre-merge approved label Oct 21, 2026

Mgluhovskoi merged commit 6c172f3 into NVIDIA:release/1.3 Oct 22, 2026

SimengLiu-nv mentioned this pull request Oct 22, 2026

[None][chore] Mass merge release/1.3 branch back to main (batch 2) #20843

Merged

1 task done

Conversation

Mgluhovskoi commented Oct 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Coverage

Dev Engineer Review

QA Engineer Review

Per-File QA Perspective

Uh oh!

Mgluhovskoi commented Oct 21, 2026

Uh oh!

Mgluhovskoi commented Oct 21, 2026

Uh oh!

coderabbitai Bot commented Oct 21, 2026

Walkthrough

Changes

Uh oh!

tensorrt-cicd commented Oct 21, 2026

Uh oh!

tensorrt-cicd commented Oct 21, 2026

Uh oh!

tensorrt-cicd commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

tensorrt-cicd commented Oct 22, 2026

Uh oh!

Mgluhovskoi commented Oct 22, 2026

Uh oh!

tensorrt-cicd commented Oct 22, 2026

Uh oh!

tensorrt-cicd commented Oct 22, 2026

Uh oh!

Mgluhovskoi commented Oct 22, 2026

Uh oh!

tensorrt-cicd commented Oct 22, 2026

Uh oh!

tensorrt-cicd commented Oct 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Mgluhovskoi commented Oct 21, 2026 •

edited by coderabbitai Bot

Loading