Skip to content

[https://nvbugs/6891162][fix] Stop test_generate_with_stop_words on the token Qwen3 generates for N #20673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenfeiz0326 merged 2 commits into from
Oct 23, 2026
Merged

[https://nvbugs/6891162][fix] Stop test_generate_with_stop_words on the token Qwen3 generates for N #20673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26e6e82
[https://nvbugs/6891162][fix] Stop test_generate_with_stop_words on t…
trtllm-agent Oct 20, 2026
3d8b8e3
Merge branch 'main' into repair-bot-v2/nvbug-6891162-r7
chenfeiz0326 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/integration/test_lists/waives.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,6 @@ unittest/executor/test_rpc.py::TestRpcCorrectness::test_incremental_task_async S
unittest/executor/test_rpc_proxy.py SKIP (https://nvbugs/5605741)
unittest/executor/test_rpc_worker.py SKIP (https://nvbugs/5605741)
unittest/llmapi/test_llm.py::test_generate_with_bad_words SKIP (https://nvbugs/6891162)
unittest/llmapi/test_llm.py::test_generate_with_stop_words SKIP (https://nvbugs/6891162)
unittest/llmapi/test_llm_args.py::TestKvCacheManagerV2AutoResolution::test_required_v2_refuses_incompatible_disagg[nixl-cpp] SKIP (https://nvbugs/6917693)
unittest/llmapi/test_llm_args.py::TestKvCacheManagerV2AutoResolution::test_required_v2_refuses_incompatible_disagg[ucx-python] SKIP (https://nvbugs/6917693)
unittest/llmapi/test_llm_kv_cache_events.py::test_llm_api_attention_dp_kv_events SKIP (https://nvbugs/6891163)
Expand Down
5 changes: 4 additions & 1 deletion tests/unittest/llmapi/test_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,10 @@ def test_generate_with_stop_words():
model=llama_model_path,
kv_cache_config=global_kvcache_config,
)
stop_id = llm.tokenizer.encode("N", add_special_tokens=False)[-1]
# The model continues "A B C" with space-separated letters, so the token
# it generates for N is the space-prefixed " N"; with BPE tokenizers
# (e.g. Qwen3) that differs from the token of a bare "N".
stop_id = llm.tokenizer.encode(" N", add_special_tokens=False)[-1]

llm_check_output(llm,
prompts, ["D E F G H I J K L M"],
Expand Down