Skip to content

[None][test] move cases to multinode test list - #20132

Merged
crazydemo merged 1 commit into
NVIDIA:release/1.3from
crazydemo:update_test_list
Oct 12, 2026
Merged

crazydemo merged 1 commit into
NVIDIA:release/1.3from
crazydemo:update_test_list

Conversation

@crazydemo

@crazydemo crazydemo commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Dev Engineer Review

The change moves TestQwen3_8_2_4T_A95B::test_nvfp4_tp8_mtp3_trtllm from the core QA list to the multinode QA list. No source or test implementation changes are reported. The test also appears in the l0_gb300_multi_nodes_node2_gpu8.yml CI list with a 60-minute timeout.

QA Engineer Review

The change modifies two QA test-list files. It removes the test from llm_function_core.txt and adds it to llm_function_multinode.txt. The test targets Qwen3 NVFP4 tensor-parallel 8 with MTP3 using TRT-LLM. The CI list also includes this test. Coverage verdict: sufficient.

Per-File QA Perspective

  • tests/integration/test_lists/qa/llm_function_core.txt: Removes the Qwen3 NVFP4 TP8 MTP3 test from the core manual-QA list.
  • tests/integration/test_lists/qa/llm_function_multinode.txt: Adds that test to the multinode manual-QA list. The matching CI test entry exists in tests/integration/test_lists/test-db/l0_gb300_multi_nodes_node2_gpu8.yml.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
@crazydemo
crazydemo requested a review from a team as a code owner October 12, 2026 05:53
@crazydemo
crazydemo requested a review from LarryXFly October 12, 2026 05:53
@crazydemo

Copy link
Copy Markdown
Collaborator Author

/bot run

@crazydemo
crazydemo enabled auto-merge (squash) October 12, 2026 05:53
@crazydemo
crazydemo requested review from xinhe-nv and removed request for LarryXFly October 12, 2026 05:54
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 1291d7ed-30bd-4529-a139-e6dba6936ed5


📥 Commits

Reviewing files that changed from the base of the PR and between 986ae6b and b51b836.



📒 Files selected for processing (2)
  • tests/integration/test_lists/qa/llm_function_core.txt
  • tests/integration/test_lists/qa/llm_function_multinode.txt


💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/qa/llm_function_core.txt


Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.




Walkthrough

The Qwen3 NVFP4 TP8 MTP3 TRT-LLM test entry was removed from the core integration test list and added to the multinode integration test list.

Changes

Test list reassignment

Layer / File(s) Summary
Move test entry
tests/integration/test_lists/qa/llm_function_core.txt, tests/integration/test_lists/qa/llm_function_multinode.txt
The test entry was removed from the core list and added to the multinode list.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b51b8

The test is categorized as multinode and remains selected by a checked-in post-merge workflow; no concrete merge-blocking risk is evident.

Pre-merge checks | Passed 4 | Failed 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning The required headings are present, but the Description and Test Coverage sections contain no content. The checklist is also not individually reviewed. Add a short explanation of the issue and solution, list the relevant test coverage or validation performed, and review the applicable checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly identifies the test-list change and follows the required [None][type] format.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR


🧪 Generate unit tests (beta)
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #77210 [ run ] triggered by Bot. Commit: b51b836 Link to invocation

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #77210 [ run ] completed with state SUCCESS. Commit: b51b836
/LLM/release-1.3/L0_MergeRequest_PR pipeline #156 completed with status: 'SUCCESS'

CI Report

Link to invocation

@crazydemo
crazydemo merged commit 0ea0e59 into NVIDIA:release/1.3 Oct 12, 2026
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Oct 26, 2026
… multinode test list

Forward-port of release/1.3 PR NVIDIA#20132
(release/1.3 commit 0ea0e59) to main.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 2, 2026
… multinode test list

Forward-port of release/1.3 PR NVIDIA#20132
(release/1.3 commit 0ea0e59) to main.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 2, 2026
… multinode test list

Forward-port of release/1.3 PR NVIDIA#20132
(release/1.3 commit 0ea0e59) to main.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 3, 2026
… multinode test list

Forward-port of release/1.3 PR NVIDIA#20132
(release/1.3 commit 0ea0e59) to main.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 3, 2026
… multinode test list

Forward-port of release/1.3 PR NVIDIA#20132
(release/1.3 commit 0ea0e59) to main.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
SimengLiu-nv pushed a commit to SimengLiu-nv/TensorRT-LLM that referenced this pull request Nov 3, 2026
… multinode test list

Forward-port of release/1.3 PR NVIDIA#20132
(release/1.3 commit 0ea0e59) to main.

Signed-off-by: Ivy Zhang <25222398+crazydemo@users.noreply.github.com>
Signed-off-by: Simeng Liu <simengl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants