Skip to content

[None][fix] Cherry-pick #19591 trtllm-gen FMHA artifacts to release/1.3 - #19956

Merged
pengbowang-nv merged 1 commit into
NVIDIA:release/1.3from
pengbowang-nv:dev-cherry-pick-pr19591-release-1.3
Oct 9, 2026
Merged

pengbowang-nv merged 1 commit into
NVIDIA:release/1.3from
pengbowang-nv:dev-cherry-pick-pr19591-release-1.3

Conversation

@pengbowang-nv

@pengbowang-nv pengbowang-nv commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

Cherry-pick of #19591 (main commit f08592ada02b8b7b94db68ee6972f3ebcecd857d) onto release/1.3 as a0dd7bcd7cc5738b0c262e8ea481d8ca5767f21c.

Update trtllm-gen to main@f8a7d6e2004bb9b7c864b33246f18c33b20cdd47, as in the original PR. This cherry-pick has no changes beyond the original FMHA artifact update.

Test Coverage

  • No build or runtime tests were rerun for this cherry-pick.
  • git diff --check passed, and the FMHA Git tree matches the original merged main commit.

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why.

  • PR follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions).

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities.

  • CODEOWNERS updated if ownership changes.

  • Documentation updated as needed.

  • Update tava architecture diagram if there is a significant design change in PR.

  • Please check this after reviewing the above items as appropriate for this PR.

Signed-off-by: Pengbo Wang <221450789+pengbowang-nv@users.noreply.github.com>
(cherry picked from commit f08592a)
@pengbowang-nv
pengbowang-nv requested a review from a team as a code owner October 8, 2026 05:41
@pengbowang-nv pengbowang-nv changed the title [None][chore] Cherry-pick trtllm-gen FMHA artifacts to release/1.3 [None][fix] Cherry-pick #19591 trtllm-gen FMHA artifacts to release/1.3 Oct 8, 2026
@pengbowang-nv

Copy link
Copy Markdown
Collaborator Author

/bot run

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76676 [ run ] triggered by Bot. Commit: a0dd7bc Link to invocation

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #76676 [ run ] completed with state SUCCESS. Commit: a0dd7bc
/LLM/release-1.3/L0_MergeRequest_PR pipeline #90 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

CI Report

Link to invocation

@farazkh80 farazkh80 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mDtypeKv is set from the K dtype only, so for the new FP8-K/NVFP4-V kernels the SwapsAb generation check would pick NVRTC instead of the cubin.

Should we derive it from both K and V, or reject the K=E4m3/V=E2m1 pair on release/1.3 until that is done?

@pengbowang-nv

Copy link
Copy Markdown
Collaborator Author

@farazkh80 The new kernels are not enabled by trtllm so far and I would say it's not an enabled feature. It should be fixed and enabled when the kernel is needed. So I prefer to keep the PR as it is, a pure update to trtllm library without enabling new features.

@pengbowang-nv
pengbowang-nv merged commit 7114bc1 into NVIDIA:release/1.3 Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

✅ LFS objects already in storage (7534 files) — no sync needed.

These LFS-tracked files are already present in this repository's LFS storage:

  • cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/cubin/FmhaSm100aKernel_QE4m3KvE2m1OBfloat16H128PagedKvCausalP32VarSeqQ256Kv128PersistentContext.cubin.tar.zst
  • cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/cubin/FmhaSm100aKernel_QE4m3KvE2m1OBfloat16H128PagedKvCausalP32VarSeqQ256Kv128StaticContext.cubin.tar.zst
  • cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/cubin/FmhaSm100aKernel_QE4m3KvE2m1OBfloat16H128PagedKvCustomP32MultiCtasKvCgaVarSeqQ16Kv128StaticSwapsAbForGen.cubin.tar.zst
  • cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/cubin/FmhaSm100aKernel_QE4m3KvE2m1OBfloat16H128PagedKvCustomP32MultiCtasKvCgaVarSeqQ32Kv128StaticSwapsAbForGen.cubin.tar.zst
  • cpp/tensorrt_llm/kernels/trtllmGenKernels/fmha/cubin/FmhaSm100aKernel_QE4m3KvE2m1OBfloat16H128PagedKvCustomP32MultiCtasKvCgaVarSeqQ8Kv128StaticSwapsAbForGen.cubin.tar.zst
  • ...and 7529 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants