Skip to content

[None][infra] Waive 2 failed cases for main in pre-merge 61872 - #19572

Merged
HuiGao-NV merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260923-013449
Sep 23, 2026
Merged

HuiGao-NV merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260923-013449

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch: main
Bug(s): 6825571

Waive entries added

full:CPU/unittest/_torch/disaggregation/test_disagg_coordinator_errors.py::test_refused_python_cancel_is_retried_and_settled_through_the_real_response_path SKIP (https://nvbugs/6825571)
unittest/_torch/disaggregation/test_disagg_coordinator_errors.py::test_cancelling_part_of_a_saturated_receive_batch_settles_only_those_requests SKIP (https://nvbugs/6825571)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

The change adds two SKIP waivers to tests/integration/test_lists/waives.txt for disaggregation coordinator error tests tracked by bug 6825571. The scope is limited to test-list configuration. No source or public API changes are present.

QA Engineer Review

The change modifies only tests/integration/test_lists/waives.txt. It waives:

  • test_refused_python_cancel_is_retried_and_settled_through_the_real_response_path
  • test_cancelling_part_of_a_saturated_receive_batch_settles_only_those_requests

Both entries target disaggregation coordinator error handling and are tracked by bug 6825571. Coverage verdict: needs follow-up, because the waiver suppresses two failing pre-merge cases; the underlying failures still require resolution.

Per-File QA Perspective

  • tests/integration/test_lists/waives.txt: Adds two skip entries for disaggregation coordinator error tests. The entries affect CI test selection and do not modify test implementation; confirm the waivers remain scoped to the listed tests and are removed after bug 6825571 is fixed.

Bug(s): 6825571
Requested by: @HuiGao-NV

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 45ba5861-3c14-4620-b3ea-c3084cfab0b3

📥 Commits

Reviewing files that changed from the base of the PR and between 134fa24 and 694ebb8.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The integration waiver list now skips two disaggregation coordinator error tests. Both entries reference NVIDIA bug 6825571.

Changes

Integration test waivers

Layer / File(s) Summary
Add test waiver entries
tests/integration/test_lists/waives.txt
Adds skip entries for two tests linked to NVIDIA bug 6825571.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: brnguyen2

Merge Risk: ⚪ Minimal · up to 694eb

The requested test waivers are narrowly scoped to the two bug-tracked cases.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies an infrastructure change that waives two failed cases on main for pre-merge 61872.
Description check ✅ Passed The description explains the waiver purpose, target branch, bug ID, requested-by information, and both exact test entries. It does not include the template headings or checklist, but the available inf…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@HuiGao-NV
HuiGao-NV enabled auto-merge (squash) September 23, 2026 01:37
@HuiGao-NV

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive 2 cases"

@HuiGao-NV
HuiGao-NV self-requested a review September 23, 2026 01:40

@HuiGao-NV HuiGao-NV left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown

Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements.

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #75154 [ skip ] triggered by Bot. Commit: 694ebb8 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #75154 [ skip ] completed with state SUCCESS. Commit: 694ebb8
Skipping testing for commit 694ebb8

Link to invocation

@HuiGao-NV
HuiGao-NV merged commit 6390f3a into NVIDIA:main Sep 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants