Repository navigation
[None][infra] Waive 2 failed cases for main in pre-merge 61872 - #19572
Conversation
Bug(s): 6825571 Requested by: @HuiGao-NV Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: NVIDIA/TensorRT-LLM/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe integration waiver list now skips two disaggregation coordinator error tests. Both entries reference NVIDIA bug 6825571. ChangesIntegration test waivers
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The requested test waivers are narrowly scoped to the two bug-tracked cases. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot skip --comment "waive 2 cases" |
|
Automatically added "ci: full pre-merge approved" because this PR has satisfied the required GitHub review approvals. Unresolved review conversations and other required checks remain independent merge requirements. |
|
PR_Github #75154 [ skip ] triggered by Bot. Commit: |
|
PR_Github #75154 [ skip ] completed with state |
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @HuiGao-NV)
Target branch:
mainBug(s): 6825571
Waive entries added
This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Dev Engineer Review
The change adds two
SKIPwaivers totests/integration/test_lists/waives.txtfor disaggregation coordinator error tests tracked by bug 6825571. The scope is limited to test-list configuration. No source or public API changes are present.QA Engineer Review
The change modifies only
tests/integration/test_lists/waives.txt. It waives:test_refused_python_cancel_is_retried_and_settled_through_the_real_response_pathtest_cancelling_part_of_a_saturated_receive_batch_settles_only_those_requestsBoth entries target disaggregation coordinator error handling and are tracked by bug 6825571. Coverage verdict: needs follow-up, because the waiver suppresses two failing pre-merge cases; the underlying failures still require resolution.
Per-File QA Perspective
tests/integration/test_lists/waives.txt: Adds two skip entries for disaggregation coordinator error tests. The entries affect CI test selection and do not modify test implementation; confirm the waivers remain scoped to the listed tests and are removed after bug 6825571 is fixed.