Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): fix typos #1939

Closed
wants to merge 2 commits into from
Closed

chore(docs): fix typos #1939

wants to merge 2 commits into from

Conversation

lfz941
Copy link
Contributor

@lfz941 lfz941 commented Jul 12, 2024

fix some typos and grammar errors to enhance documents

Copy link

@LynseyFabel LynseyFabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments.

docs/source/advanced/expert-parallelism.md Outdated Show resolved Hide resolved
docs/source/advanced/expert-parallelism.md Outdated Show resolved Hide resolved
@nv-guomingz
Copy link
Collaborator

@lfz941 Please update the MR per our engineer's comment.

Apply suggestion changes

Co-authored-by: LynseyFabel <[email protected]>
@lfz941
Copy link
Contributor Author

lfz941 commented Jul 25, 2024

updated. sorry for the late response.

@nv-guomingz
Copy link
Collaborator

@LynseyFabel Could we merge this MR now?

@LynseyFabel
Copy link

LGTM!

@nv-guomingz nv-guomingz added Documentation Improvements or additions to documentation Merged and removed waiting for feedback labels Jul 29, 2024
@nv-guomingz
Copy link
Collaborator

Hi @lfz941 , thanks for your contribution to TRT-LLM. We've merged this PR internally.

@kaiyux kaiyux mentioned this pull request Aug 7, 2024
@hchings hchings closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants