Skip to content

[None][fix] Exempt SSM pages from the page-index release assertion #18610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thorjohnsen wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Draft

[None][fix] Exempt SSM pages from the page-index release assertion #18610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions cpp/tensorrt_llm/batch_manager/kv_cache_manager_v2/page.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,13 @@ void SharedPageLock::releasePageIndex()
{
int oldBaseIndex
= mUser.kvCache->updateBasePageIndex(mUser.beamIndex, mUser.ordinal, mUser.lifeCycle, kBadPageIndex.value());
// Mirrors Python assertion: old base index must match this page's slot ID.
TLLM_CHECK_DEBUG(oldBaseIndex == slotIdToPageIndexValue(page()->slotId()));
// Mirrors Python assertion: old base index must match this page's slot ID -- except for SSM
// pages, which are locked with kBadBlockOrdinal because they have no per-block index slot.
// updateBasePageIndex() tracks nothing for those and reports kBadPageIndex, so comparing
// against the page's slot would fail for every SSM page (_page.py SharedPageLock.unlock()
// carries the same exemption; the port dropped it).
TLLM_CHECK_DEBUG(oldBaseIndex
== (mUser.ordinal == kBadBlockOrdinal ? kBadPageIndex.value() : slotIdToPageIndexValue(page()->slotId())));
(void) oldBaseIndex;
}

Expand Down
Loading