[None][test] Don't force disable_overlap_scheduler for perf-sanity ctx_only tests - #18346
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe performance test no longer forces Changesctx_only configuration handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized harness change lets ctx-only performance tests honor the scheduler setting from their configuration; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Description checkExplanation The description includes the required Description, Test Coverage, and PR Checklist sections. It explains the issue, the solution, validation across all 96 configurations, baseline impact, and checklist status. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…x_only tests The ctx_only mode builds an aggregated server config out of the disaggregated yaml's worker_config.ctx section, and unconditionally overwrote disable_overlap_scheduler with True. The overlap scheduler works fine for a context-only run, so use the value from the yaml like every other worker_config.ctx knob. All but 6 of the CI disagg configs set ctx disable_overlap_scheduler: false, so their e2e/gen_only tests already run the ctx worker with the overlap scheduler enabled while ctx_only ran it disabled. The perf baselines of those ctx_only cases are expected to shift once. Signed-off-by: chenfeiz0326 <203214996+chenfeiz0326@users.noreply.github.com>
c96a463 to
0df65b2
Compare
|
/bot skip --comment "Only update config for ctx only perf tests, no need to run the whole CI pipeline" |
|
PR_Github #69895 [ skip ] triggered by Bot. Commit: |
|
PR_Github #69895 [ skip ] completed with state |
Description
The
ctx_onlymode of the perf-sanity suite (aggr[_upload]-ctx_only-<disagg config>)builds an aggregated server config out of the disaggregated yaml's
worker_config.ctxsection. While doing so it unconditionally overwrote the ctx worker's
disable_overlap_schedulerwithTrue:The overlap scheduler works fine for a context-only run, so this override is removed and
the value comes from the yaml like every other
worker_config.ctxknob.90 of the 96 CI disagg configs set ctx
disable_overlap_scheduler: false(since #17390),so their
e2e/gen_onlytests already run the ctx worker with the overlap schedulerenabled while the
ctx_onlytest generated from the same config file ran it disabled. The6
gb300_nemotron-ultra-v3-fp4_*configs that set ctxdisable_overlap_scheduler: truekeep running with the overlap scheduler off.
When the key is absent from a yaml,
ServerConfigalready defaults it toFalse, whichmatches both the LLM API default and the aggregated tests. Spec-decode modes that cannot
support the overlap scheduler are still handled by the runtime:
py_executor_creator.pysets
disable_overlap_scheduler = Trueitself and logs a warning whenspec_config.spec_dec_mode.support_overlap_scheduler()is false.Impact on baselines
This changes the measured configuration of the existing ctx_only cases (90 of 96 flip from
overlap-off to overlap-on), so their perf baselines are expected to shift once after merge.
Test Coverage
Harness-only change. Verified by driving
_parse_disagg_config_fileinctx_onlymodeover all 96 configs in
tests/scripts/perf-sanity/disaggregated/and inspecting thegenerated
extra-llm-api-configcontent:disable_overlap_schedulerfalsefalsetruetruecache_transceiver_configis still dropped in every case.PR Checklist
PR description clearly explains what and why.
PR follows the TRT-LLM coding guidelines.
Harness-only change; verified against all 96 CI disagg configs (see Test Coverage). No API change.
No new dependencies.
No documentation change needed.
Please check this after reviewing the above items as appropriate for this PR.
Note on pre-commit:
ruff format --check,ruff checkand the whitespace/EOL checks wererun against the modified file and pass. The full
pre-commit run --all-filescould not beexecuted in this environment (hook virtualenv creation fails on a missing
platformdirs),so please flag anything the CI formatting stage catches.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.Dev Engineer Review
ctx_onlynow honorsworker_config.ctx.disable_overlap_scheduler.Trueoverride.ServerConfigdefault ofFalse.truevalues remain unchanged.QA Engineer Review
ctx_only.disable_overlap_scheduler: true.