Skip to content

[None][fix] Drop the unbound is_idle guard left in the idle disagg CTX reap #18263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tburt-nv merged 1 commit into from
Aug 26, 2026
Merged

[None][fix] Drop the unbound is_idle guard left in the idle disagg CTX reap #18263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tensorrt_llm/_torch/pyexecutor/py_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3610,7 +3610,7 @@ def _check_disagg_transfer_progress_when_idle(self) -> None:
# A single-rank CTX worker cannot diverge on a collective. Reap
# completed sends while it is idle so their pinned KV blocks can
# be reused by the next context requests.
if (is_idle and self._dist_size(self.dist, "world_size") == 1 and
if (self._dist_size(self.dist, "world_size") == 1 and
self.async_transfer_manager.has_any_inflight_requests()):
self._check_disagg_ctx_cache_transfer_status(0)
return
Expand Down
9 changes: 1 addition & 8 deletions tests/unittest/_torch/executor/test_py_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,14 +1040,7 @@ def test_sync_single_rank_ctx_reaps_idle_transfer(
executor._check_disagg_gen_cache_transfer_status = Mock()
executor._check_disagg_ctx_cache_transfer_status = Mock()

PyExecutor._check_disagg_transfer_progress_when_idle(
executor,
num_fitting_reqs=0,
fitting_disagg_gen_init_requests=[],
wait_for_disagg_gen_transfer_progress=True,
all_gen_first=False,
is_idle=True,
)
PyExecutor._check_disagg_transfer_progress_when_idle(executor)

executor.dist.allreduce.assert_not_called()
executor.dist.tp_allreduce.assert_not_called()
Expand Down
Loading