[https://nvbugs/6647310][chore] Unwaive TestLagunaXS::test_nvfp4 - #18219
Conversation
Signed-off-by: qgai <qgai@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughRemoved the skipped Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This PR only removes the waiver for the specified test; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: Description checkExplanation The description explains the issue, identifies the root-cause fix, states the exact file change, and provides relevant pre-merge CI coverage. It uses Summary, Changes, and Test plan sections instead of the template's Description and Test Coverage headings, and it omits the PR Checklist, but the required technical information is mostly complete. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
/bot run |
|
PR_Github #69281 [ run ] triggered by Bot. Commit: |
|
PR_Github #69281 [ run ] completed with state |
|
@brnguyen2 could you help review this PR? thanks |
Summary
accuracy/test_llm_api_pytorch.py::TestLagunaXS::test_nvfp4(waived under https://nvbugs/6647310).SessionPrefetcher.take()handed over a prefetched pool with no live worker, and the next test polledworker_init_status_queueuntil the 3600 s pytest timeout.take()now verifies every recorded worker's(pid, start_time)identity before handover, discards dead pools, and falls back to synchronous session creation.Changes
tests/integration/test_lists/waives.txt: remove theTestLagunaXS::test_nvfp4SKIP entry.Test plan
l0_b200.ymlschedulesTestLagunaXS::test_nvfp4).Dev Engineer Review
TestLagunaXS::test_nvfp4waiver and itsnvbugs/6647310reference fromtests/integration/test_lists/waives.txt.#17642.QA Engineer Review
accuracy/test_llm_api_pytorch.py::TestLagunaXS::test_nvfp4entry fromwaives.txt.l0_b200.ymlschedule is expected to provide CI coverage.