Repository navigation
[https://nvbugs/6640776][fix] Bump CUTLASS DSL to 4.6.2 to unblock FA4 split-KV #18145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
09afb67
[nvbugs/6640776][fix] Fix the FA4 sm100 compile and centralize the FA…
trtllm-agent 0082bbc
[https://nvbugs/6640776][chore] Drop the import-hardening refactors f…
luyiyun1021 b932b97
[https://nvbugs/6640776][test] Cover the FA4 split-KV kernel
luyiyun1021 09aec66
[https://nvbugs/6640776][infra] Trigger multi-GPU tests on kernel-sta…
luyiyun1021 cf0df69
[https://nvbugs/6640776][chore] Refresh the CUTLASS DSL attribution v…
luyiyun1021 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
tensorrt_llm/_torch/visual_gen/attention_backend/_flash_attn_cute.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Resolution of optional FlashAttention 4 CuTe symbols. | ||
|
|
||
| Shared by the backends that consume ``flash_attn.cute.interface`` so the | ||
| optional-dependency contract is defined once instead of per import site. | ||
| """ | ||
|
|
||
| import importlib | ||
| from typing import Any, Callable, Optional | ||
|
|
||
|
|
||
| def resolve_flash_attn_cute_symbol( | ||
| name: str, | ||
| ) -> tuple[Optional[Callable[..., Any]], Optional[BaseException]]: | ||
| """Return ``(symbol, None)`` if FlashAttention 4 provides ``name``, else ``(None, error)``. | ||
|
|
||
| Callers keep the returned error and raise it at first use, so an unusable FA4 | ||
| degrades to a ``None`` sentinel instead of breaking module import. | ||
|
|
||
| Every failure mode is treated as "FA4 unusable" rather than enumerating | ||
| exception types: a *broken* install -- present, but built against a different | ||
| CuTe DSL -- fails while executing ``flash_attn``'s module body and surfaces as | ||
| whatever that line happens to raise (e.g. ``AttributeError`` for a DSL symbol | ||
| that has since been removed), not as ``ImportError``. This package's | ||
| ``__init__`` imports its backends unconditionally, so an escaping exception | ||
| would take down every importer of ``visual_gen`` -- including ``VisualGen`` | ||
| itself, whose model packages pull in ``attention_backend.parallel``. | ||
| """ | ||
| try: | ||
| return getattr(importlib.import_module("flash_attn.cute.interface"), name), None | ||
| except Exception as e: # noqa: BLE001 - any failure means FA4 is unusable here | ||
| return None, e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.