[None][fix] Restore CpType import for HELIX KV cache - #18143
Conversation
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe utility module now imports ChangesContext-parallel import
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized fix restores the import required by existing HELIX KV-cache paths without changing product behavior or public interfaces. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/bot skip --comment "Hotfix for release check" |
|
PR_Github #68830 [ skip ] triggered by Bot. Commit: |
|
PR_Github #68830 [ skip ] completed with state |
|
Sorry for the inconvenience @chzblych. When drafting the PR, in PR's baseline codebase |
Signed-off-by: Yanchao Lu <yanchaol@nvidia.com>
Description
#18025 removed the
CpTypeimport while deleting star-attention support, buttensorrt_llm/_torch/pyexecutor/_util.pystill usesCpType.HELIXin the HELIX KV-cache estimation and capacity paths. This leaves those references undefined and causes the baseline-gated legacy lint check to fail.Restore the shared
CpTypeimport. This is an internal one-line fix with no API or runtime behavior change beyond making the existing HELIX paths valid again.Test Coverage
python3 scripts/legacy_utils.py lint-precommit tensorrt_llm/_torch/pyexecutor/_util.pyruff check --config ruff-legacy.toml --select F821 tensorrt_llm/_torch/pyexecutor/_util.pygit diff --checkPR Checklist
PR description clearly explains what and why.
PR follows the TRT-LLM coding guidelines.
No API changes, new dependencies, ownership changes, documentation changes, or architecture changes.
The targeted CI-equivalent lint checks pass.
Please check this after reviewing the above items as appropriate for this PR.
Dev Engineer Review
CpTypeimport intensorrt_llm/_torch/pyexecutor/_util.py.CpType.HELIXreferences in HELIX KV-cache estimation and capacity paths.QA Engineer Review
No test changes.