[https://nvbugs/6428063][chore] Unwaive the DeepSeekV3Lite nvfp4 pp4 test - #18139
Conversation
…y the NVIDIA#15920 revert Signed-off-by: Lori Ren <lorir@nvidia.com>
|
/bot run --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2, GB300-4_GPUs-PyTorch-Post-Merge-1, GB300-4_GPUs-PyTorch-Post-Merge-2, GB300-4_GPUs-PyTorch-Post-Merge-3, RTXPro6000D-PyTorch-Post-Merge-1" |
|
PR_Github #68802 [ run ] triggered by Bot. Commit: |
|
PR_Github #68802 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2, GB300-4_GPUs-PyTorch-Post-Merge-1, GB300-4_GPUs-PyTorch-Post-Merge-2, GB300-4_GPUs-PyTorch-Post-Merge-3, RTXPro6000D-PyTorch-Post-Merge-1" |
|
PR_Github #69023 [ run ] triggered by Bot. Commit: |
|
PR_Github #69023 [ run ] completed with state
|
|
/bot run --extra-stage "DGX_B300-4_GPUs-PyTorch-Post-Merge-1, DGX_B300-4_GPUs-PyTorch-Post-Merge-2, GB300-4_GPUs-PyTorch-Post-Merge-1, GB300-4_GPUs-PyTorch-Post-Merge-2, GB300-4_GPUs-PyTorch-Post-Merge-3, RTXPro6000D-PyTorch-Post-Merge-1" --disable-fail-fast |
|
PR_Github #69068 [ run ] triggered by Bot. Commit: |
|
PR_Github #69068 [ run ] completed with state |
Description
use_host_stop_criteria(added by #15920) was reverted wholesale by #16163, so the mechanismbehind nvbugs/6428063 no longer exists —
grep -rn use_host_stop_criteriareturns nothing onmain. The waiver has been skipping this case since 2026-07-08 and has not been touched since.This removes that one line and nothing else:
Supersedes #16136, whose fix (threading the flag through the PP ring-broadcast payload in
py_executor.py) targets code that no longer exists: against today'smainitsgetattralways yields
Falseand itshasattrguard never fires.Test Coverage
The un-waived case itself:
accuracy/test_llm_api_pytorch.py::TestDeepSeekV3Lite::test_nvfp4_4gpus[moe_backend=CUTLASS-mtp_nextn=0-pp4-fp8kv=True-attention_dp=True-cuda_graph=True-overlap_scheduler=True-low_precision_combine=False-torch_compile=True]It is listed in
l0_dgx_b300.yml,l0_gb300_multi_gpus.ymlandl0_rtx_pro_6000.yml, allstage: post_merge. nvfp4 requires Blackwell, so the run is requested on all three.Note for reviewers
waives.txtcarries 11 other waivers on this same test function under six unrelated bugs(6384625, 5961814, 6422432, 6245394, 6474888, 6655987) covering different
moe_backend/parallelism/mtp_nextncombinations. Only the 6428063 line is touched here.PR Checklist
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.