Skip to content

[TRTLLMINF-136][infra] Strengthen check_test_list.py param-ID validation and gate on validate<->collection parity #17975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brnguyen2 merged 11 commits into from
Aug 21, 2026
Merged

[TRTLLMINF-136][infra] Strengthen check_test_list.py param-ID validation and gate on validate<->collection parity #17975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f6cd3d3
[TRTLLMINF-136][infra] Strengthen check_test_list.py AST param-ID val…
brnguyen2 Aug 19, 2026
a0419dd
[TRTLLMINF-136][infra] Add validate<->collection parity gate to check…
brnguyen2 Aug 19, 2026
0948a2c
[TRTLLMINF-136][infra] Require --validate and --l0/--qa for --parity
brnguyen2 Aug 19, 2026
ddae070
[TRTLLMINF-136][infra] Address review: const-mutation soundness, empt…
brnguyen2 Aug 19, 2026
af95d41
[TRTLLMINF-136][infra] Extend const-soundness guard to def/class/del;…
brnguyen2 Aug 19, 2026
65be320
Address trivial review comments
brnguyen2 Aug 20, 2026
368a2ff
[None][fix] Keep sysinfo distro probe working without the distro modu…
brnguyen2 Aug 20, 2026
dde38bc
[TRTLLMINF-136][ci] Drop duplicated renderTestDB guard; keep only dis…
brnguyen2 Aug 20, 2026
7583916
test waives: skip kv_cache/test_kv_cache_v2_scheduler.py::TestKVCache…
brnguyen2 Aug 20, 2026
910c631
[TRTLLMINF-136][test] Cover stale qa_test.txt removal in parity path
brnguyen2 Aug 21, 2026
120abda
Merge branch 'main' into brnguyen/validate-param-ids
brnguyen2 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/precommit-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,13 @@ jobs:
else
python3 -u scripts/release_check.py
fi

# Informational only: list test-list entries whose parametrize IDs cannot
# be verified statically (runtime-computed argvalues/ids), grouped by
# reason, so they can be swept without rerunning the analysis locally. The
# pre-commit step above remains the gate for actual validation errors;
# this step never fails the job.
- name: Report unverifiable test-list param IDs
if: always()
continue-on-error: true
run: python3 -u scripts/check_test_list.py --validate --report-unverifiable
4 changes: 3 additions & 1 deletion jenkins/L0_Test.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3818,7 +3818,9 @@ def launchTestListCheck(pipeline)
def llmPath = sh (script: "realpath .", returnStdout: true).trim()
def llmSrc = "${llmPath}/TensorRT-LLM/src"
trtllm_utils.llmExecStepWithRetry(pipeline, script: "pip3 install -r ${llmSrc}/requirements-dev.txt")
sh "NVIDIA_TRITON_SERVER_VERSION=26.05 LLM_ROOT=${llmSrc} LLM_BACKEND_ROOT=${llmSrc}/triton_backend python3 ${llmSrc}/scripts/check_test_list.py --l0 --qa --waive"
// --validate --parity: after --l0/--qa generate the collectable lists, assert every
// statically-verified parametrize ID is actually collectable (validate<->collection parity).
sh "NVIDIA_TRITON_SERVER_VERSION=26.05 LLM_ROOT=${llmSrc} LLM_BACKEND_ROOT=${llmSrc}/triton_backend python3 ${llmSrc}/scripts/check_test_list.py --l0 --qa --waive --validate --parity"
} catch (InterruptedException e) {
throw e
} catch (Exception e) {
Expand Down
Loading
Loading